Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
asus/am1i-a: update the PIRQ routing table
Update the PIRQ routing in accordance with the new IRQ tables.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: If56af736b43a0ad9d52f86a615c7888ed3f1afcc --- M src/mainboard/asus/am1i-a/irq_tables.c 1 file changed, 29 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48607/1
diff --git a/src/mainboard/asus/am1i-a/irq_tables.c b/src/mainboard/asus/am1i-a/irq_tables.c index ba58af6..0f191de 100644 --- a/src/mainboard/asus/am1i-a/irq_tables.c +++ b/src/mainboard/asus/am1i-a/irq_tables.c @@ -9,26 +9,41 @@ 0x00, /* Interrupt router bus */ (0x14 << 3) | 0x3, /* Interrupt router dev */ 0, /* IRQs devoted exclusively to PCI usage */ - 0x1002, /* Vendor */ - 0x439d, /* Device */ + 0x1022, /* Vendor */ + 0x780e, /* Device */ 0, /* Miniport */ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, /* u8 rfu[11] */ - 0x3b, /* Checksum (has to be set to some value that + 0x5e, /* Checksum (has to be set to some value that * would give 0 after the sum of all bytes * for this structure (including checksum). */ { - /* bus, dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */ - {0x00, (0x01 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, - {0x00, (0x02 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, - {0x00, (0x10 << 3) | 0x0, {{0x03, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, - {0x00, (0x11 << 3) | 0x0, {{0x04, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, - {0x00, (0x12 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, - {0x00, (0x13 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, - {0x00, (0x14 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, - {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, - {0x01, (0x00 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, - {0x02, (0x00 << 3) | 0x0, {{0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, + /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ + /* APU Integrated Graphics: 0:01.00 - IRQ 3 */ + /* APU HDMI Audio Controller: 0:01.01 - IRQ 4 */ + {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* PCIe GPP to dGPU 1:00.00: 0:02.01 - IRQ 3 */ + /* PCIe GPP to Eth 2:00.00: 0:02.05 - IRQ 4 */ + {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, + /* USB XHCI: 0:10.00 - IRQ 5 */ + {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* SATA: 0:11.00 - IRQ 7 */ + {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* USB OHCI1: 0:12.00 - IRQ 5 */ + /* USB EHCI1: 0:12.02 - IRQ 4 */ + {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* USB OHCI2: 0:13.00 - IRQ 5 */ + /* USB EHCI2: 0:13.02 - IRQ 4 */ + {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* USB OHCI3: 0:16.00 - IRQ 5 */ + /* USB EHCI3: 0:16.02 - IRQ 4 */ + {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, + /* Southbridge HD Audio: 0:14.02 - IRQ 3 */ + {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, + /* Discrete Graphics (dGPU) 1:00.00 behind a 0:02.01 PCIe GPP - IRQ 3 */ + {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x1, 0x0}, + /* Onboard Ethernet (Eth) 2:00.00 behind a 0:02.05 PCIe GPP - IRQ 4 */ + {0x02, (0x00 << 3) | 0x0, {{0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0}, {0x01, 0xccb0} }, 0x2, 0x0} } };
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... File src/mainboard/asus/am1i-a/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 21: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 24: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 27: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 29: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 31: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 34: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 37: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 40: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 44: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x1, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/1/src/mainboard/asus/am1i-a/i... PS1, Line 46: {0x02, (0x00 << 3) | 0x0, {{0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0}, {0x01, 0xccb0} }, 0x2, 0x0} line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
Patch Set 2:
(11 comments)
File src/mainboard/asus/am1i-a/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/48607/comment/cd436e04_5ee31782 PS2, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/adeda1ff_9ce2c906 PS2, Line 25: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/ae3d6ffc_cb9e6e45 PS2, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/1700ae6a_4e4a34ac PS2, Line 30: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/1a66cd38_b4beb3fb PS2, Line 32: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/631273aa_077ce4d9 PS2, Line 35: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/335012dd_59c63b7d PS2, Line 38: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/7426ba85_277710ad PS2, Line 41: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/877a4b58_5bc9eab2 PS2, Line 43: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/b90a0409_645ef063 PS2, Line 45: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x1, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/71bcef38_159b0166 PS2, Line 47: {0x02, (0x00 << 3) | 0x0, {{0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0}, {0x01, 0xccb0} }, 0x2, 0x0} line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
Patch Set 3:
(11 comments)
File src/mainboard/asus/am1i-a/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/48607/comment/e92b75b3_704c714e PS3, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/2374bf43_3c51e86f PS3, Line 25: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/b8759de7_80ee4075 PS3, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/ba363047_0f388e5d PS3, Line 30: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/0709e701_c0dd4df7 PS3, Line 32: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/5f0503a7_25c29df4 PS3, Line 35: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/528e3e5b_ef5dc759 PS3, Line 38: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/8e60ae0a_e0339944 PS3, Line 41: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/31e67b28_23d5620b PS3, Line 43: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/47f56a3b_b1727566 PS3, Line 45: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x1, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/48607/comment/db211be3_6cdfa7c8 PS3, Line 47: {0x02, (0x00 << 3) | 0x0, {{0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0}, {0x01, 0xccb0} }, 0x2, 0x0} line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
Patch Set 4:
(11 comments)
File src/mainboard/asus/am1i-a/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/717a7ac4_51a4402c PS4, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/e1b39919_0ff46c50 PS4, Line 25: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/05c89d2e_0bf35cbe PS4, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/ce411d1e_829643b0 PS4, Line 30: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/97a0e4a4_49bc2537 PS4, Line 32: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/acdb36d8_62a4ad55 PS4, Line 35: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/e2617cdf_9441b6de PS4, Line 38: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/67f8ed4f_845f0841 PS4, Line 41: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/1f531090_92e94693 PS4, Line 43: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/a2f9c77a_addc6b95 PS4, Line 45: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x1, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117715): https://review.coreboot.org/c/coreboot/+/48607/comment/f6ef3a07_c6900b82 PS4, Line 47: {0x02, (0x00 << 3) | 0x0, {{0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0}, {0x01, 0xccb0} }, 0x2, 0x0} line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
Patch Set 5:
(11 comments)
File src/mainboard/asus/am1i-a/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/12f0afab_ac04550e PS5, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/dce7e78b_e9d39bc3 PS5, Line 25: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/c12494fc_451fee47 PS5, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/4054e3f6_691ef021 PS5, Line 30: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/3af86c1f_06f432e5 PS5, Line 32: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/d2b1a5a5_3b18a385 PS5, Line 35: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/c0b48859_3ce25eb8 PS5, Line 38: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/015f2e74_fe496846 PS5, Line 41: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/a2a9fa69_2a3f61d7 PS5, Line 43: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/f5ad1e56_6d700391 PS5, Line 45: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x1, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131804): https://review.coreboot.org/c/coreboot/+/48607/comment/945d93c7_cafc45f0 PS5, Line 47: {0x02, (0x00 << 3) | 0x0, {{0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0}, {0x01, 0xccb0} }, 0x2, 0x0} line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
Patch Set 6:
(11 comments)
File src/mainboard/asus/am1i-a/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/f6a37d72_12af3b64 PS6, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/7219c4c1_693c47fe PS6, Line 25: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/52b10d78_a1d1d567 PS6, Line 28: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/2d762c63_ec65ffce PS6, Line 30: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/80673b94_46881e74 PS6, Line 32: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/480f5322_d2cf0634 PS6, Line 35: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/d36b63bf_71559543 PS6, Line 38: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/95f0e9e9_8847b533 PS6, Line 41: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xccb0}, {0x02, 0xccb0}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/c5761fb6_43581cd2 PS6, Line 43: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/b6810b7a_34ca1a6d PS6, Line 45: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xccb0}, {0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0} }, 0x1, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131812): https://review.coreboot.org/c/coreboot/+/48607/comment/d137f762_5b549fc2 PS6, Line 47: {0x02, (0x00 << 3) | 0x0, {{0x02, 0xccb0}, {0x03, 0xccb0}, {0x04, 0xccb0}, {0x01, 0xccb0} }, 0x2, 0x0} line over 96 characters
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48607 )
Change subject: asus/am1i-a: update the PIRQ routing table ......................................................................
Abandoned
Abandoned in favor of CB:58756