Attention is currently required from: Michał Żygowski, Paul Menzel, Michał Kopeć, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66265 )
Change subject: superio/nuvoton/nct6687d: Fix unexpected expression
......................................................................
Patch Set 3:
(1 comment)
File src/superio/nuvoton/nct6687d/superio.c:
https://review.coreboot.org/c/coreboot/+/66265/comment/c855b0e3_af8f3b0a
PS2, Line 35: uint8_t byte;
: uint8_t power_status;
One indentation level less, and the compiler should optimize them out?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie369454f10b515aa5601a5e78330e12f4b7a5e4c
Gerrit-Change-Number: 66265
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Nov 2022 18:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment