Change in coreboot[master]: [WIP] AGESA, binaryPI: Remove generic device for SPD eeproms
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: [WIP] AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
[WIP] AGESA, binaryPI: Remove generic device for SPD eeproms
Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/amd/bettong/devicetree.cb M src/mainboard/amd/gardenia/devicetree.cb M src/mainboard/amd/inagua/devicetree.cb M src/mainboard/amd/lamar/devicetree.cb M src/mainboard/amd/olivehill/devicetree.cb M src/mainboard/amd/olivehillplus/devicetree.cb M src/mainboard/amd/parmer/devicetree.cb M src/mainboard/amd/persimmon/devicetree.cb M src/mainboard/amd/thatcher/devicetree.cb M src/mainboard/amd/torpedo/devicetree.cb M src/mainboard/asrock/e350m1/devicetree.cb M src/mainboard/asrock/imb-a180/devicetree.cb M src/mainboard/asus/am1i-a/devicetree.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb M src/mainboard/biostar/am1ml/devicetree.cb M src/mainboard/elmex/pcm205400/devicetree.cb M src/mainboard/hp/abm/devicetree.cb M src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb M src/mainboard/jetway/nf81-t56n-lf/devicetree.cb M src/mainboard/lenovo/g505s/devicetree.cb M src/mainboard/lippert/frontrunner-af/devicetree.cb M src/mainboard/lippert/toucan-af/devicetree.cb M src/mainboard/msi/ms7721/devicetree.cb 25 files changed, 0 insertions(+), 156 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/35102/1
diff --git a/src/mainboard/amd/bettong/devicetree.cb b/src/mainboard/amd/bettong/devicetree.cb index 84aaf41..e318b6d 100644 --- a/src/mainboard/amd/bettong/devicetree.cb +++ b/src/mainboard/amd/bettong/devicetree.cb @@ -43,12 +43,6 @@ device pci 11.0 on end # SATA device pci 12.0 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM #device pci 14.2 on end # HDA 0x4383 device pci 14.3 on end # LPC 0x439d diff --git a/src/mainboard/amd/gardenia/devicetree.cb b/src/mainboard/amd/gardenia/devicetree.cb index e9946ad..beee845 100644 --- a/src/mainboard/amd/gardenia/devicetree.cb +++ b/src/mainboard/amd/gardenia/devicetree.cb @@ -41,9 +41,6 @@ device pci 11.0 on end # SATA device pci 12.0 on end # EHCI device pci 14.0 on # SM - chip drivers/generic/generic # dimm 0-0-0 - device i2c 51 on end - end end # SM device pci 14.3 on end # LPC 0x790e device pci 14.7 on end # SD diff --git a/src/mainboard/amd/inagua/devicetree.cb b/src/mainboard/amd/inagua/devicetree.cb index 578c654..cc28124 100644 --- a/src/mainboard/amd/inagua/devicetree.cb +++ b/src/mainboard/amd/inagua/devicetree.cb @@ -38,12 +38,6 @@ device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/amd/lamar/devicetree.cb b/src/mainboard/amd/lamar/devicetree.cb index d7f3f05..e57a6c6 100644 --- a/src/mainboard/amd/lamar/devicetree.cb +++ b/src/mainboard/amd/lamar/devicetree.cb @@ -54,18 +54,6 @@ device pci 13.0 on end # 0x7807 USB OHCI device pci 13.2 on end # 0x7808 USB EHCI device pci 14.0 on # 0x780B SMBus - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - chip drivers/generic/generic #dimm 0-1-0 - device i2c 52 on end - end - chip drivers/generic/generic #dimm 0-1-1 - device i2c 53 on end - end end # SM device pci 14.1 on end # 0x780C IDE device pci 14.2 on end # 0x780D HDA diff --git a/src/mainboard/amd/olivehill/devicetree.cb b/src/mainboard/amd/olivehill/devicetree.cb index bf8d476..a7933ce 100644 --- a/src/mainboard/amd/olivehill/devicetree.cb +++ b/src/mainboard/amd/olivehill/devicetree.cb @@ -41,12 +41,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on end # LPC 0x439d diff --git a/src/mainboard/amd/olivehillplus/devicetree.cb b/src/mainboard/amd/olivehillplus/devicetree.cb index 430b17b..4b47642d 100644 --- a/src/mainboard/amd/olivehillplus/devicetree.cb +++ b/src/mainboard/amd/olivehillplus/devicetree.cb @@ -42,12 +42,6 @@ device pci 12.0 on end # EHCI #0 device pci 13.0 on end # EHCI #1 device pci 14.0 on # SMBus - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SMbus device pci 14.2 on end # HDA 0x4383 device pci 14.3 on end # LPC 0x439d diff --git a/src/mainboard/amd/parmer/devicetree.cb b/src/mainboard/amd/parmer/devicetree.cb index e619def..7e0fc2c 100644 --- a/src/mainboard/amd/parmer/devicetree.cb +++ b/src/mainboard/amd/parmer/devicetree.cb @@ -44,12 +44,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/amd/persimmon/devicetree.cb b/src/mainboard/amd/persimmon/devicetree.cb index 323e7f2..40ea282 100644 --- a/src/mainboard/amd/persimmon/devicetree.cb +++ b/src/mainboard/amd/persimmon/devicetree.cb @@ -37,12 +37,6 @@ device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/amd/thatcher/devicetree.cb b/src/mainboard/amd/thatcher/devicetree.cb index 4ae1ba9..a55fa25 100644 --- a/src/mainboard/amd/thatcher/devicetree.cb +++ b/src/mainboard/amd/thatcher/devicetree.cb @@ -44,12 +44,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/amd/torpedo/devicetree.cb b/src/mainboard/amd/torpedo/devicetree.cb index 2adfb27..00923ea 100644 --- a/src/mainboard/amd/torpedo/devicetree.cb +++ b/src/mainboard/amd/torpedo/devicetree.cb @@ -42,12 +42,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.1 on end # IDE device pci 14.2 on end # HDA diff --git a/src/mainboard/asrock/e350m1/devicetree.cb b/src/mainboard/asrock/e350m1/devicetree.cb index e374c41..5d368fa 100644 --- a/src/mainboard/asrock/e350m1/devicetree.cb +++ b/src/mainboard/asrock/e350m1/devicetree.cb @@ -39,12 +39,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/asrock/imb-a180/devicetree.cb b/src/mainboard/asrock/imb-a180/devicetree.cb index 2c4a4aa..3ade19b 100644 --- a/src/mainboard/asrock/imb-a180/devicetree.cb +++ b/src/mainboard/asrock/imb-a180/devicetree.cb @@ -42,12 +42,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on diff --git a/src/mainboard/asus/am1i-a/devicetree.cb b/src/mainboard/asus/am1i-a/devicetree.cb index 53114c1..763761a 100644 --- a/src/mainboard/asus/am1i-a/devicetree.cb +++ b/src/mainboard/asus/am1i-a/devicetree.cb @@ -43,12 +43,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb index 349a845..c95fe84 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb @@ -47,12 +47,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb index af0e4cc..3e39ef3 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb @@ -47,12 +47,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb index 238ab51..e261505 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb @@ -38,18 +38,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 52 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 2 - device i2c 51 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 3 - device i2c 53 on end # 7-bit SPD address - end end # SM device pci 14.1 off end # unused device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/biostar/am1ml/devicetree.cb b/src/mainboard/biostar/am1ml/devicetree.cb index 400653d..e6adc0a 100644 --- a/src/mainboard/biostar/am1ml/devicetree.cb +++ b/src/mainboard/biostar/am1ml/devicetree.cb @@ -42,12 +42,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.1 on end # there is no legacy ide device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/elmex/pcm205400/devicetree.cb b/src/mainboard/elmex/pcm205400/devicetree.cb index 405f3e0..d11529b 100644 --- a/src/mainboard/elmex/pcm205400/devicetree.cb +++ b/src/mainboard/elmex/pcm205400/devicetree.cb @@ -37,12 +37,6 @@ device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 off end # HDA 0x4383 diff --git a/src/mainboard/hp/abm/devicetree.cb b/src/mainboard/hp/abm/devicetree.cb index c7a7510..2786f78 100644 --- a/src/mainboard/hp/abm/devicetree.cb +++ b/src/mainboard/hp/abm/devicetree.cb @@ -41,9 +41,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end end # SM device pci 14.2 off end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb index ad59974..35ccca7 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb +++ b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb @@ -41,12 +41,6 @@ device pci 13.0 on end # USB device pci 13.2 on end # USB device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb index 6289438..faed1c5 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb +++ b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb @@ -38,12 +38,6 @@ device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/lenovo/g505s/devicetree.cb b/src/mainboard/lenovo/g505s/devicetree.cb index 99f42d6..5be9111 100644 --- a/src/mainboard/lenovo/g505s/devicetree.cb +++ b/src/mainboard/lenovo/g505s/devicetree.cb @@ -45,12 +45,6 @@ device pci 13.0 on end # FCH USB OHCI Controller device pci 13.2 on end # FCH USB EHCI Controller device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end end # SM device pci 14.2 on end # FCH Azalia Controller device pci 14.3 on # FCH LPC Bridge [1022:780e] diff --git a/src/mainboard/lippert/frontrunner-af/devicetree.cb b/src/mainboard/lippert/frontrunner-af/devicetree.cb index b72059a..5e84fcb 100644 --- a/src/mainboard/lippert/frontrunner-af/devicetree.cb +++ b/src/mainboard/lippert/frontrunner-af/devicetree.cb @@ -37,12 +37,6 @@ device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 off end - end end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/lippert/toucan-af/devicetree.cb b/src/mainboard/lippert/toucan-af/devicetree.cb index cb9aa8e..25d84db 100644 --- a/src/mainboard/lippert/toucan-af/devicetree.cb +++ b/src/mainboard/lippert/toucan-af/devicetree.cb @@ -38,12 +38,6 @@ device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 off end - end end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 diff --git a/src/mainboard/msi/ms7721/devicetree.cb b/src/mainboard/msi/ms7721/devicetree.cb index d3991f1..1c73404 100644 --- a/src/mainboard/msi/ms7721/devicetree.cb +++ b/src/mainboard/msi/ms7721/devicetree.cb @@ -46,12 +46,6 @@ device pci 13.0 on end # USB OHCI device pci 13.2 on end # USB EHCI device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # Azalia (Audio)
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: [WIP] AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
Patch Set 1:
Will this affect padmelon (review 33993)? I believe so. When should I change it?
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35102
to look at the new patch set (#3).
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
AGESA, binaryPI: Remove generic device for SPD eeproms
Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/amd/bettong/devicetree.cb M src/mainboard/amd/gardenia/devicetree.cb M src/mainboard/amd/inagua/devicetree.cb M src/mainboard/amd/lamar/devicetree.cb M src/mainboard/amd/olivehill/devicetree.cb M src/mainboard/amd/olivehillplus/devicetree.cb M src/mainboard/amd/padmelon/devicetree.cb M src/mainboard/amd/parmer/devicetree.cb M src/mainboard/amd/persimmon/devicetree.cb M src/mainboard/amd/thatcher/devicetree.cb M src/mainboard/amd/torpedo/devicetree.cb M src/mainboard/asrock/e350m1/devicetree.cb M src/mainboard/asrock/imb-a180/devicetree.cb M src/mainboard/asus/am1i-a/devicetree.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb M src/mainboard/biostar/am1ml/devicetree.cb M src/mainboard/elmex/pcm205400/devicetree.cb M src/mainboard/hp/abm/devicetree.cb M src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb M src/mainboard/jetway/nf81-t56n-lf/devicetree.cb M src/mainboard/lenovo/g505s/devicetree.cb M src/mainboard/lippert/frontrunner-af/devicetree.cb M src/mainboard/lippert/toucan-af/devicetree.cb M src/mainboard/msi/ms7721/devicetree.cb 26 files changed, 22 insertions(+), 208 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/35102/3
Hello Alexander Couzens, Patrick Rudolph, Marshall Dawson, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35102
to look at the new patch set (#4).
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
AGESA, binaryPI: Remove generic device for SPD eeproms
Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/amd/bettong/devicetree.cb M src/mainboard/amd/gardenia/devicetree.cb M src/mainboard/amd/inagua/devicetree.cb M src/mainboard/amd/lamar/devicetree.cb M src/mainboard/amd/olivehill/devicetree.cb M src/mainboard/amd/olivehillplus/devicetree.cb M src/mainboard/amd/padmelon/devicetree.cb M src/mainboard/amd/parmer/devicetree.cb M src/mainboard/amd/persimmon/devicetree.cb M src/mainboard/amd/thatcher/devicetree.cb M src/mainboard/asrock/e350m1/devicetree.cb M src/mainboard/asrock/imb-a180/devicetree.cb M src/mainboard/asus/am1i-a/devicetree.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb M src/mainboard/biostar/am1ml/devicetree.cb M src/mainboard/elmex/pcm205400/devicetree.cb M src/mainboard/hp/abm/devicetree.cb M src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb M src/mainboard/jetway/nf81-t56n-lf/devicetree.cb M src/mainboard/lenovo/g505s/devicetree.cb M src/mainboard/lippert/frontrunner-af/devicetree.cb M src/mainboard/lippert/toucan-af/devicetree.cb M src/mainboard/msi/ms7721/devicetree.cb 25 files changed, 21 insertions(+), 200 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/35102/4
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35102/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35102/4//COMMIT_MSG@8 PS4, Line 8: I can see what you are doing and have nothing against... but I believe you should explain why on the commit message.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
Patch Set 4: Code-Review+2
Hello Alexander Couzens, Patrick Rudolph, Angel Pons, Marshall Dawson, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35102
to look at the new patch set (#5).
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
AGESA, binaryPI: Remove generic device for SPD eeproms
These entries have no functional purpose, followup work will disallow chip entries that do not link in the respective driver.
Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/amd/bettong/devicetree.cb M src/mainboard/amd/gardenia/devicetree.cb M src/mainboard/amd/inagua/devicetree.cb M src/mainboard/amd/lamar/devicetree.cb M src/mainboard/amd/olivehill/devicetree.cb M src/mainboard/amd/olivehillplus/devicetree.cb M src/mainboard/amd/padmelon/devicetree.cb M src/mainboard/amd/parmer/devicetree.cb M src/mainboard/amd/persimmon/devicetree.cb M src/mainboard/amd/thatcher/devicetree.cb M src/mainboard/asrock/e350m1/devicetree.cb M src/mainboard/asrock/imb-a180/devicetree.cb M src/mainboard/asus/am1i-a/devicetree.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb M src/mainboard/biostar/am1ml/devicetree.cb M src/mainboard/elmex/pcm205400/devicetree.cb M src/mainboard/hp/abm/devicetree.cb M src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb M src/mainboard/jetway/nf81-t56n-lf/devicetree.cb M src/mainboard/lenovo/g505s/devicetree.cb M src/mainboard/lippert/frontrunner-af/devicetree.cb M src/mainboard/lippert/toucan-af/devicetree.cb M src/mainboard/msi/ms7721/devicetree.cb 25 files changed, 25 insertions(+), 206 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/35102/5
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
Patch Set 5: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35102/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35102/4//COMMIT_MSG@8 PS4, Line 8:
I can see what you are doing and have nothing against... […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35102 )
Change subject: AGESA, binaryPI: Remove generic device for SPD eeproms ......................................................................
AGESA, binaryPI: Remove generic device for SPD eeproms
These entries have no functional purpose, followup work will disallow chip entries that do not link in the respective driver.
Change-Id: Ieab695022d0dd2f2671f9058db97bdd6fb29a10d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35102 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/bettong/devicetree.cb M src/mainboard/amd/gardenia/devicetree.cb M src/mainboard/amd/inagua/devicetree.cb M src/mainboard/amd/lamar/devicetree.cb M src/mainboard/amd/olivehill/devicetree.cb M src/mainboard/amd/olivehillplus/devicetree.cb M src/mainboard/amd/padmelon/devicetree.cb M src/mainboard/amd/parmer/devicetree.cb M src/mainboard/amd/persimmon/devicetree.cb M src/mainboard/amd/thatcher/devicetree.cb M src/mainboard/asrock/e350m1/devicetree.cb M src/mainboard/asrock/imb-a180/devicetree.cb M src/mainboard/asus/am1i-a/devicetree.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb M src/mainboard/biostar/am1ml/devicetree.cb M src/mainboard/elmex/pcm205400/devicetree.cb M src/mainboard/hp/abm/devicetree.cb M src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb M src/mainboard/jetway/nf81-t56n-lf/devicetree.cb M src/mainboard/lenovo/g505s/devicetree.cb M src/mainboard/lippert/frontrunner-af/devicetree.cb M src/mainboard/lippert/toucan-af/devicetree.cb M src/mainboard/msi/ms7721/devicetree.cb 25 files changed, 25 insertions(+), 206 deletions(-)
Approvals: build bot (Jenkins): Verified Richard Spiegel: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/amd/bettong/devicetree.cb b/src/mainboard/amd/bettong/devicetree.cb index 84aaf41..c447bca 100644 --- a/src/mainboard/amd/bettong/devicetree.cb +++ b/src/mainboard/amd/bettong/devicetree.cb @@ -42,14 +42,7 @@ device pci 10.0 on end # USB device pci 11.0 on end # SATA device pci 12.0 on end # USB - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM #device pci 14.2 on end # HDA 0x4383 device pci 14.3 on end # LPC 0x439d device pci 14.7 on end # SD diff --git a/src/mainboard/amd/gardenia/devicetree.cb b/src/mainboard/amd/gardenia/devicetree.cb index e9946ad..027a820 100644 --- a/src/mainboard/amd/gardenia/devicetree.cb +++ b/src/mainboard/amd/gardenia/devicetree.cb @@ -40,11 +40,7 @@ device pci 10.0 on end # xHCI device pci 11.0 on end # SATA device pci 12.0 on end # EHCI - device pci 14.0 on # SM - chip drivers/generic/generic # dimm 0-0-0 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.3 on end # LPC 0x790e device pci 14.7 on end # SD device pci 18.0 on end diff --git a/src/mainboard/amd/inagua/devicetree.cb b/src/mainboard/amd/inagua/devicetree.cb index 578c654..946bd59 100644 --- a/src/mainboard/amd/inagua/devicetree.cb +++ b/src/mainboard/amd/inagua/devicetree.cb @@ -37,14 +37,7 @@ device pci 12.2 on end # EHCI USB 0-4 device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/amd/lamar/devicetree.cb b/src/mainboard/amd/lamar/devicetree.cb index d7f3f05..5c88a3c 100644 --- a/src/mainboard/amd/lamar/devicetree.cb +++ b/src/mainboard/amd/lamar/devicetree.cb @@ -53,20 +53,7 @@ device pci 12.2 on end # 0x7808 USB EHCI device pci 13.0 on end # 0x7807 USB OHCI device pci 13.2 on end # 0x7808 USB EHCI - device pci 14.0 on # 0x780B SMBus - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - chip drivers/generic/generic #dimm 0-1-0 - device i2c 52 on end - end - chip drivers/generic/generic #dimm 0-1-1 - device i2c 53 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 on end # 0x780C IDE device pci 14.2 on end # 0x780D HDA device pci 14.3 on # 0x780E LPC diff --git a/src/mainboard/amd/olivehill/devicetree.cb b/src/mainboard/amd/olivehill/devicetree.cb index bf8d476..b29d327 100644 --- a/src/mainboard/amd/olivehill/devicetree.cb +++ b/src/mainboard/amd/olivehill/devicetree.cb @@ -40,14 +40,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on end # LPC 0x439d device pci 14.7 on end # SD diff --git a/src/mainboard/amd/olivehillplus/devicetree.cb b/src/mainboard/amd/olivehillplus/devicetree.cb index 430b17b..9b59d99 100644 --- a/src/mainboard/amd/olivehillplus/devicetree.cb +++ b/src/mainboard/amd/olivehillplus/devicetree.cb @@ -41,14 +41,7 @@ device pci 11.0 on end # SATA device pci 12.0 on end # EHCI #0 device pci 13.0 on end # EHCI #1 - device pci 14.0 on # SMBus - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SMbus + device pci 14.0 on end # SMBus device pci 14.2 on end # HDA 0x4383 device pci 14.3 on end # LPC 0x439d device pci 14.7 on end # SD diff --git a/src/mainboard/amd/padmelon/devicetree.cb b/src/mainboard/amd/padmelon/devicetree.cb index fa83d10..be0fdfc 100644 --- a/src/mainboard/amd/padmelon/devicetree.cb +++ b/src/mainboard/amd/padmelon/devicetree.cb @@ -45,14 +45,7 @@ device pci 10.0 on end # USB xHCI device pci 11.0 on end # SATA device pci 12.0 on end # USB EHCI - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-1-0 - device i2c 52 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.3 on # LPC 0x439d chip superio/fintek/f81803a device pnp 4e.1 on # COM1 diff --git a/src/mainboard/amd/parmer/devicetree.cb b/src/mainboard/amd/parmer/devicetree.cb index e619def..aad3413 100644 --- a/src/mainboard/amd/parmer/devicetree.cb +++ b/src/mainboard/amd/parmer/devicetree.cb @@ -43,14 +43,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SMBUS device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on end # LPC 0x439d diff --git a/src/mainboard/amd/persimmon/devicetree.cb b/src/mainboard/amd/persimmon/devicetree.cb index 323e7f2..73cf19d 100644 --- a/src/mainboard/amd/persimmon/devicetree.cb +++ b/src/mainboard/amd/persimmon/devicetree.cb @@ -36,14 +36,7 @@ device pci 12.2 on end # EHCI USB 0-4 device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/amd/thatcher/devicetree.cb b/src/mainboard/amd/thatcher/devicetree.cb index 4ae1ba9..fd4cbef 100644 --- a/src/mainboard/amd/thatcher/devicetree.cb +++ b/src/mainboard/amd/thatcher/devicetree.cb @@ -43,14 +43,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SMBUS device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/asrock/e350m1/devicetree.cb b/src/mainboard/asrock/e350m1/devicetree.cb index e374c41..b6ec209 100644 --- a/src/mainboard/asrock/e350m1/devicetree.cb +++ b/src/mainboard/asrock/e350m1/devicetree.cb @@ -38,14 +38,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC diff --git a/src/mainboard/asrock/imb-a180/devicetree.cb b/src/mainboard/asrock/imb-a180/devicetree.cb index 2c4a4aa..536236e 100644 --- a/src/mainboard/asrock/imb-a180/devicetree.cb +++ b/src/mainboard/asrock/imb-a180/devicetree.cb @@ -41,14 +41,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on chip superio/winbond/w83627uhg diff --git a/src/mainboard/asus/am1i-a/devicetree.cb b/src/mainboard/asus/am1i-a/devicetree.cb index 53114c1..8e44874 100644 --- a/src/mainboard/asus/am1i-a/devicetree.cb +++ b/src/mainboard/asus/am1i-a/devicetree.cb @@ -42,14 +42,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d chip superio/ite/it8623e diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb index 349a845..7a22d78 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m.cb @@ -46,14 +46,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SMBUS device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb index af0e4cc..7d0e820 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_le.cb @@ -46,14 +46,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SMBUS device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb index f13e3e8..97405aa 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb @@ -37,20 +37,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 52 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 2 - device i2c 51 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 3 - device i2c 53 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SMBUS device pci 14.1 off end # unused device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x780e diff --git a/src/mainboard/biostar/am1ml/devicetree.cb b/src/mainboard/biostar/am1ml/devicetree.cb index 400653d..dfe537c 100644 --- a/src/mainboard/biostar/am1ml/devicetree.cb +++ b/src/mainboard/biostar/am1ml/devicetree.cb @@ -41,14 +41,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 on end # there is no legacy ide device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/elmex/pcm205400/devicetree.cb b/src/mainboard/elmex/pcm205400/devicetree.cb index 405f3e0..902b892 100644 --- a/src/mainboard/elmex/pcm205400/devicetree.cb +++ b/src/mainboard/elmex/pcm205400/devicetree.cb @@ -36,14 +36,7 @@ device pci 12.2 on end # EHCI USB 0-4 device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 on end # IDE 0x439c device pci 14.2 off end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/hp/abm/devicetree.cb b/src/mainboard/hp/abm/devicetree.cb index c7a7510..cd0b354 100644 --- a/src/mainboard/hp/abm/devicetree.cb +++ b/src/mainboard/hp/abm/devicetree.cb @@ -40,11 +40,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.2 off end # HDA 0x4383 device pci 14.3 on # LPC 0x439d chip superio/nuvoton/nct5104d diff --git a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb index ad59974..8d705ed 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb +++ b/src/mainboard/hp/pavilion_m6_1035dx/devicetree.cb @@ -40,14 +40,7 @@ device pci 12.2 on end # USB device pci 13.0 on end # USB device pci 13.2 on end # USB - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SM device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d chip ec/compal/ene932 diff --git a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb index 6289438..b5d51ef 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb +++ b/src/mainboard/jetway/nf81-t56n-lf/devicetree.cb @@ -37,14 +37,7 @@ device pci 12.2 on end # EHCI USB 0-4 device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 on end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/lenovo/g505s/devicetree.cb b/src/mainboard/lenovo/g505s/devicetree.cb index 99f42d6..623a78b 100644 --- a/src/mainboard/lenovo/g505s/devicetree.cb +++ b/src/mainboard/lenovo/g505s/devicetree.cb @@ -44,14 +44,7 @@ device pci 12.2 on end # FCH USB EHCI Controller device pci 13.0 on end # FCH USB OHCI Controller device pci 13.2 on end # FCH USB EHCI Controller - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SMBUS device pci 14.2 on end # FCH Azalia Controller device pci 14.3 on # FCH LPC Bridge [1022:780e] chip ec/compal/ene932 diff --git a/src/mainboard/lippert/frontrunner-af/devicetree.cb b/src/mainboard/lippert/frontrunner-af/devicetree.cb index b72059a..0f89d25 100644 --- a/src/mainboard/lippert/frontrunner-af/devicetree.cb +++ b/src/mainboard/lippert/frontrunner-af/devicetree.cb @@ -36,14 +36,7 @@ device pci 12.2 on end # EHCI USB 0-4 device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 off end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/lippert/toucan-af/devicetree.cb b/src/mainboard/lippert/toucan-af/devicetree.cb index cb9aa8e..ce05afc 100644 --- a/src/mainboard/lippert/toucan-af/devicetree.cb +++ b/src/mainboard/lippert/toucan-af/devicetree.cb @@ -37,14 +37,7 @@ device pci 12.2 on end # EHCI USB 0-4 device pci 13.0 on end # OHCI USB 5-9 device pci 13.2 on end # EHCI USB 5-9 - device pci 14.0 on # SM - chip drivers/generic/generic #dimm 0-0-0 - device i2c 50 on end - end - chip drivers/generic/generic #dimm 0-0-1 - device i2c 51 off end - end - end # SM + device pci 14.0 on end # SM device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x439d diff --git a/src/mainboard/msi/ms7721/devicetree.cb b/src/mainboard/msi/ms7721/devicetree.cb index d3991f1..cb86074 100644 --- a/src/mainboard/msi/ms7721/devicetree.cb +++ b/src/mainboard/msi/ms7721/devicetree.cb @@ -45,14 +45,7 @@ device pci 12.2 on end # USB EHCI device pci 13.0 on end # USB OHCI device pci 13.2 on end # USB EHCI - device pci 14.0 on # SMBUS - chip drivers/generic/generic #dimm 0 - device i2c 50 on end # 7-bit SPD address - end - chip drivers/generic/generic #dimm 1 - device i2c 51 on end # 7-bit SPD address - end - end # SM + device pci 14.0 on end # SMBUS device pci 14.1 off end # IDE 0x439c device pci 14.2 on end # Azalia (Audio) device pci 14.3 on # LPC 0x439d
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Richard Spiegel (Code Review)