John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51225 )
Change subject: [TEST]mb/google/zork/variants/vilboz: Override phy driving to fix the eDP noise ......................................................................
[TEST]mb/google/zork/variants/vilboz: Override phy driving to fix the eDP noise
Override phy driving to fix th eDP noise for WWAN.
BUG=b:171269338 BRANCH=zork TEST=Check COMMON_MAR_DEEMPH_NOM register and no noise
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: I672a001a312e9142c213d463670e1ac825d17299 --- M src/mainboard/google/zork/variants/vilboz/variant.c 1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/51225/1
diff --git a/src/mainboard/google/zork/variants/vilboz/variant.c b/src/mainboard/google/zork/variants/vilboz/variant.c index 3816aac..daf84e5 100644 --- a/src/mainboard/google/zork/variants/vilboz/variant.c +++ b/src/mainboard/google/zork/variants/vilboz/variant.c @@ -40,8 +40,18 @@ soc_cfg = config_of_soc();
/* b:/174121847 Use external OSC to mitigate noise for WWAN sku. */ - if (variant_has_wwan()) + if (variant_has_wwan()) { soc_cfg->acp_i2s_use_external_48mhz_osc = 1; + + /* b:171269338 Improve WWAN noise floor to + adjust the phy driving setting */ + soc_cfg->edp_phy_override = ENABLE_EDP_TUNINGSET; + soc_cfg->edp_physel = 0x1; + soc_cfg->edp_tuningset.dp_vs_pemph_level = 0x1; + soc_cfg->edp_tuningset.margin_deemph = 0x004b; + soc_cfg->edp_tuningset.deemph_6db4 = 0x0; + soc_cfg->edp_tuningset.boostadj = 0x80; + } }
/*