Attention is currently required from: Cliff Huang, Dolan Liu, Eric Lai, Kapil Porwal, Lance Zhao, Subrata Banik, Tim Wawrzynczak.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email )
Change subject: acpi: Add acpi_device_write_dsd_gpio for public
......................................................................
Patch Set 9:
(4 comments)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/81788/comment/89c6d435_a9f2dc30 :
PS6, Line 46:
I would like to add check the pointer in case of NULL pointer. […]
Done
https://review.coreboot.org/c/coreboot/+/81788/comment/1ddaec21_68e19a7e :
PS6, Line 51: ret = *curr_index;
ret = *curr_index++;
Done
https://review.coreboot.org/c/coreboot/+/81788/comment/aa2483c6_741cf55c :
PS6, Line 52: (*curr_index)++;
don't need
Done
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/81788/comment/df787ce5_3cbdfd8a :
PS7, Line 47: !gpio
| !curr_index
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment