Attention is currently required from: Angel Pons, Kyösti Mälkki, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78090?usp=email )
Change subject: sb/intel/common/spi: Fix I/O alignment
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78090/comment/402602ef_ff37427f :
PS1, Line 18: byte haven't
hasn’t?
Done
https://review.coreboot.org/c/coreboot/+/78090/comment/079c4d04_9fda54bf :
PS1, Line 20: qemu
Maybe add the version.
Done
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/78090/comment/f334a0ca_9f5c20ba :
PS1, Line 320: (uint8_t *)
nit: cast shouldn't be needed
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78090?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id05b1a080911b71b94ef781c6e26d98165f02f67
Gerrit-Change-Number: 78090
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 06 Oct 2023 07:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment