Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19386 )
Change subject: drivers/spi: Re-factor spi_crop_chunk ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/#/c/19386/2//COMMIT_MSG Commit Message:
PS2, Line 14: Size of 0 indicates any transfer size is fine
Dot/period at end of sentence.
Done
PS2, Line 17: ).
Switch the ) and ..
Done
PS2, Line 13: 1. max_xfer_size: Maximum transfer size supported by the controller : (Size of 0 indicates any transfer size is fine) : 2. deduct_cmd_len: Whether cmd_len needs to be deducted from the : max_xfer_size to determine max data size that can be : transferred. (This is used by the amd boards).
Add a line break to make the enumeration more visible?
Done
https://review.coreboot.org/#/c/19386/2/src/include/spi-generic.h File src/include/spi-generic.h:
PS2, Line 91: contoller
you can fix this tipo while here :)
Done
PS2, Line 99: (0 = No limit)
what about using UINTMAX_MAX for no limit to make it more explicit?
Done
PS2, Line 113: deduct_cmd_len
thinking about someone implementing a new SPI controller using max_xfer_siz
I have added an assert in spi_crop_chunk to ensure that max_xfer_size is not 0 for the controllers that require use of the crop chunk.