Hello Satya Priya Kakitapalli,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37254
to review the following change.
Change subject: libpayload: Add BIT(x) macro definition ......................................................................
libpayload: Add BIT(x) macro definition
Add BIT(x) macro definition in libpayload.
Change-Id: I15ca2d3758d516cecf9edd60af47e7fdbd808c40 Signed-off-by: satya priya skakit@codeaurora.org --- M payloads/libpayload/include/libpayload.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/37254/1
diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 80bfaae..c53f523 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -85,6 +85,7 @@ #define MAX(a, b) __CMP(a, b, >)
#define ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0])) +#define BIT(x) (1ul << (x))
#define DIV_ROUND_UP(x, y) ({ \ typeof(x) _div_local_x = (x); \
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37254 )
Change subject: libpayload: Add BIT(x) macro definition ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37254 )
Change subject: libpayload: Add BIT(x) macro definition ......................................................................
libpayload: Add BIT(x) macro definition
Add BIT(x) macro definition in libpayload.
Change-Id: I15ca2d3758d516cecf9edd60af47e7fdbd808c40 Signed-off-by: satya priya skakit@codeaurora.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37254 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M payloads/libpayload/include/libpayload.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 0bd5db8..934c368 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -85,6 +85,7 @@ #define MAX(a, b) __CMP(a, b, >)
#define ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0])) +#define BIT(x) (1ul << (x))
#define DIV_ROUND_UP(x, y) ({ \ typeof(x) _div_local_x = (x); \
-
Julius Werner (Code Review) -
mturney mturney (Code Review)
-
Patrick Georgi (Code Review)