Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29531 )
Change subject: drivers/spi: Return error in failure case ......................................................................
drivers/spi: Return error in failure case
In case the function pointer isn't set return an error.
Change-Id: I9de300f651ac93889dafa7377c876bf5ae2c50cc Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/29531 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M src/drivers/spi/spi_flash.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved
diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index cc21ccb..b0b5899 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -448,7 +448,7 @@ if (!flash->ops->get_write_protection) { printk(BIOS_WARNING, "SPI: Write-protection gathering not " "implemented for this vendor.\n"); - return 0; + return -1; }
return flash->ops->get_write_protection(flash, region); @@ -473,7 +473,7 @@ if (!flash->ops->set_write_protection) { printk(BIOS_WARNING, "SPI: Setting write-protection is not " "implemented for this vendor.\n"); - return 0; + return -1; }
ret = flash->ops->set_write_protection(flash, region, non_volatile,