Attention is currently required from: Jason Glenesk, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/74291
to review the following change.
Change subject: mb/amd/birman: Add a region specifically for AMDFW ......................................................................
mb/amd/birman: Add a region specifically for AMDFW
Change-Id: Iae2ef4f886cb4796b792ce4855d87e24b32357b7 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/mainboard/amd/birman/board_phoenix_32M.fmd M src/mainboard/amd/birman/chromeos_phoenix_32M.fmd M src/soc/amd/phoenix/Makefile.inc 3 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/74291/1
diff --git a/src/mainboard/amd/birman/board_phoenix_32M.fmd b/src/mainboard/amd/birman/board_phoenix_32M.fmd index b05f343..1546335 100644 --- a/src/mainboard/amd/birman/board_phoenix_32M.fmd +++ b/src/mainboard/amd/birman/board_phoenix_32M.fmd @@ -2,11 +2,12 @@ BIOS_BOTTOM 16M { EC_SIG 4K FMAP 4K - COREBOOT(CBFS) + AMDFW(CBFS) EC_BODY@15872K 256K RW_MRC_CACHE 256K } BIOS_TOP @16M { AMDFWBODY + COREBOOT(CBFS) @8M } } diff --git a/src/mainboard/amd/birman/chromeos_phoenix_32M.fmd b/src/mainboard/amd/birman/chromeos_phoenix_32M.fmd index 750148e..52165f4 100644 --- a/src/mainboard/amd/birman/chromeos_phoenix_32M.fmd +++ b/src/mainboard/amd/birman/chromeos_phoenix_32M.fmd @@ -6,7 +6,7 @@ RO_SECTION { FMAP 2K RO_FRID 64 - COREBOOT(CBFS) + AMDFW(CBFS) GBB 448K } } @@ -34,5 +34,6 @@ } BIOS_TOP @16M { AMDFWBODY + COREBOOT(CBFS) @8M } } diff --git a/src/soc/amd/phoenix/Makefile.inc b/src/soc/amd/phoenix/Makefile.inc index 37b58dd..ae285f0 100644 --- a/src/soc/amd/phoenix/Makefile.inc +++ b/src/soc/amd/phoenix/Makefile.inc @@ -252,6 +252,10 @@ $(OPT_SPL_TABLE_FILE) \ --location $(CONFIG_AMD_FWM_POSITION) \ --output $@ +ifeq ($(CONFIG_COREBOOT_ROMSIZE_KB),32768) +regions-for-file-apu/amdfw=AMDFW +$(info region-amdfw $(call regions-for-file,apu/amdfw)) +endif
ifeq ($(CONFIG_AMDFW_SPLIT),y) $(obj)/amdfw.rom.body: $(obj)/amdfw.rom