Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48583 )
Change subject: soc/intel: hook up new gpio device in the soc chips
......................................................................
Patch Set 13: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48583/13/src/soc/intel/common/block...
File src/soc/intel/common/block/gpio/gpio_dev.c:
PS13:
I guess this could also be part of `gpio.c`.
https://review.coreboot.org/c/coreboot/+/48583/13/src/soc/intel/xeon_sp/cpx/...
File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/48583/13/src/soc/intel/xeon_sp/cpx/...
PS13, Line 64: }
Please keep the braces and add them for the new path. If one path of an
if/else-if statement has braces, all should.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48583
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81dbbf5397b28ffa7537465c53332779245b39f6
Gerrit-Change-Number: 48583
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 17 Dec 2020 20:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment