Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree ......................................................................
mb/purism/librem_mini: drop SendVrMbxCmd from devicetree
Not needed for this board.
Change-Id: I15a68b59bc512e571b9590007ea64561b3f3dae1 Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/47184/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb index 2050332..40779a2 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb @@ -4,9 +4,6 @@ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, }"
- # Send an extra VR mailbox command for the PS4 exit issue - register "SendVrMbxCmd" = "2" - # ACPI (soc/intel/cannonlake/acpi.c) # Disable s0ix register "s0ix_enable" = "0"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree ......................................................................
Patch Set 1:
What VR does the board have?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree ......................................................................
Patch Set 1:
Patch Set 1:
What VR does the board have?
I don't remember off the top of my head, but this was copy-pasted when doing the original port and removing it shows no adverse effects.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
What VR does the board have?
I don't remember off the top of my head, but this was copy-pasted when doing the original port and removing it shows no adverse effects.
Well, I'm not sure if not entering / not exiting PS4 would really show that obvious. That would need to be checked by poking VR registers. So, when Matt can tell me which VR it is, I can see if I have a datasheet :-)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47184 )
Change subject: mb/purism/librem_mini: drop SendVrMbxCmd from devicetree ......................................................................
mb/purism/librem_mini: drop SendVrMbxCmd from devicetree
Not needed for this board.
Change-Id: I15a68b59bc512e571b9590007ea64561b3f3dae1 Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/coreboot/+/47184 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb index 2050332..40779a2 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb @@ -4,9 +4,6 @@ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, }"
- # Send an extra VR mailbox command for the PS4 exit issue - register "SendVrMbxCmd" = "2" - # ACPI (soc/intel/cannonlake/acpi.c) # Disable s0ix register "s0ix_enable" = "0"
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Michael Niewöhner (Code Review)