Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60496 )
Change subject: soc/intel/apollolake/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ......................................................................
soc/intel/apollolake/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
Replace `Subtract (a, b)` with `a - b`.
Change-Id: I3b0ee96b5a1e9bf242efc14a24f745fd8ba0cd97 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60496 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/apollolake/acpi/northbridge.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/acpi/northbridge.asl b/src/soc/intel/apollolake/acpi/northbridge.asl index 1b59097..4f2acbb 100644 --- a/src/soc/intel/apollolake/acpi/northbridge.asl +++ b/src/soc/intel/apollolake/acpi/northbridge.asl @@ -83,7 +83,7 @@ And(_SB.PCI0.MCHC.MCNF, 0xF0000000, PMAX)
/* Calculate PCI MMIO Length */ - PLEN = Subtract(PMAX, PMIN) + 1 + PLEN = PMAX - PMIN + 1
/* Find GFX resource area in GCRS */ CreateDwordField(MCRS, STOM._MIN, GMIN) @@ -96,7 +96,7 @@ /* Read TOLUD */ And(_SB.PCI0.MCHC.TLUD, 0xFFF00000, GMAX) Decrement(GMAX) - GLEN = Subtract(GMAX, GMIN) + 1 + GLEN = GMAX - GMIN + 1
/* Patch PM02 range based on Memory Size */ If (LEqual (A4GS, 0)) {
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.