[L] Change in coreboot[main]: mb/topton/adl: Add initial support for X2F N100 FW appliance

[Alicja Michalska (Code Review)]

Attention is currently required from: Angel Pons.

Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/84175?usp=email )

Change subject: mb/topton/adl: Add initial support for X2F N100 FW appliance
......................................................................

Patch Set 9:

(2 comments)

File src/mainboard/topton/adl/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/84175/comment/cec59996_543bd25b?usp... :
PS2, Line 43: 		# TODO: SATA doesn't work. EDK2 returns "Unsupported", not sure how to fix (yet).
> I meant these: […]

I believe ADL-N has two SATA ports, but when I tried adding what you just mentioned - drive wasn't recognized in EDK2. While testing Windows, it complained about I/O bus error (which is honestly my first time seeing this issue, SATA usually "just works).

I did check it of course, here's a list of lspci from stock firmware (I don't enable TB4, HDA or I2C in devicetree, as there's nothing on those buses):
```
00:00.0 Host bridge [0600]: Intel Corporation Device [8086:461c]
00:02.0 VGA compatible controller [0300]: Intel Corporation Alder Lake-N [UHD Graphics] [8086:46d1] (prog-if 00 [VGA controller])
00:0d.0 USB controller [0c03]: Intel Corporation Alder Lake-N Thunderbolt 4 USB Controller [8086:464e] (prog-if 30 [XHCI])
00:14.0 USB controller [0c03]: Intel Corporation Alder Lake-N PCH USB 3.2 xHCI Host Controller [8086:54ed] (prog-if 30 [XHCI])
00:14.2 RAM memory [0500]: Intel Corporation Alder Lake-N PCH Shared SRAM [8086:54ef]
00:16.0 Communication controller [0780]: Intel Corporation Alder Lake-N PCH HECI Controller [8086:54e0]

00:17.0 SATA controller [0106]: Intel Corporation Alder Lake-N SATA AHCI Controller [8086:54d3] (prog-if 01 [AHCI 1.0])
    DeviceName: Onboard - SATA
    Subsystem: Intel Corporation Device [8086:7270]
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
    Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
    Latency: 0
    Interrupt: pin A routed to IRQ 125
    Region 0: Memory at 81100000 (32-bit, non-prefetchable) [size=8K]
    Region 1: Memory at 81103000 (32-bit, non-prefetchable) [size=256]
    Region 2: I/O ports at 3090 [size=8]
    Region 3: I/O ports at 3080 [size=4]
    Region 4: I/O ports at 3060 [size=32]
    Region 5: Memory at 81102000 (32-bit, non-prefetchable) [size=2K]
    Capabilities: [80] MSI: Enable+ Count=1/1 Maskable- 64bit-
    	Address: fee002f8  Data: 0000
    Capabilities: [70] Power Management version 3
    	Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
    	Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
    Capabilities: [a8] SATA HBA v1.0 BAR4 Offset=00000004
    Kernel driver in use: ahci

00:1c.0 PCI bridge [0604]: Intel Corporation Device [8086:54b8] (prog-if 00 [Normal decode])
00:1c.1 PCI bridge [0604]: Intel Corporation Device [8086:54b9] (prog-if 00 [Normal decode])
00:1c.2 PCI bridge [0604]: Intel Corporation Device [8086:54ba] (prog-if 00 [Normal decode])
00:1c.6 PCI bridge [0604]: Intel Corporation Device [8086:54be] (prog-if 00 [Normal decode])
00:1d.0 PCI bridge [0604]: Intel Corporation Alder Lake-N PCI Express Root Port #9 [8086:54b0] (prog-if 00 [Normal decode])
00:1f.0 ISA bridge [0601]: Intel Corporation Alder Lake-N PCH eSPI Controller [8086:5481]
00:1f.3 Audio device [0403]: Intel Corporation Alder Lake-N PCH High Definition Audio Controller [8086:54c8]
00:1f.4 SMBus [0c05]: Intel Corporation Alder Lake-N SMBus [8086:54a3]
00:1f.5 Serial bus controller [0c80]: Intel Corporation Alder Lake-N SPI (flash) Controller [8086:54a4]
01:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller I226-V [8086:125c] (rev 04)
02:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller I226-V [8086:125c] (rev 04)
03:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller I226-V [8086:125c] (rev 04)
04:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller I226-V [8086:125c] (rev 04)
05:00.0 Non-Volatile memory controller [0108]: Kingston Technology Company, Inc. OM3PDP3 NVMe SSD [2646:500d] (rev 01) (prog-if 02 [NVM Express])
```

File src/mainboard/topton/adl/mainboard.c:

https://review.coreboot.org/c/coreboot/+/84175/comment/356fa809_d4e024d3?usp... :
PS9, Line 17: 	params->PchLegacyIoLowLatency = 1;
> I think I commented on what this was, could you please add a comment so that I don't ask over and ov […]

It disables some DMI-related power saving features, I probably could remove it if I do a bit more testing. I had a lot of issues with NVME on my previous port without it.

```
Some systems require lower IO latency irrespective of power. This is a tradeoff between power and IO latency.
Note: Once this is enabled, DmiAspm, Pcie DmiAspm in SystemAgent and ITSS Clock Gating are forced to disabled.
```