Attention is currently required from: Jamie Ryu, Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Paul Menzel, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63198 )
Change subject: soc/intel/common: Implement IOC driver
......................................................................
Patch Set 17:
(4 comments)
File src/soc/intel/common/block/ioc/ioc.c:
https://review.coreboot.org/c/coreboot/+/63198/comment/7d5cdca7_4c4e75e2
PS17, Line 12: get_mchbar
You mean move get_mchbar api in systemagent_early. […]
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/2aaa0b7f_567f12b7
PS17, Line 25: void ioc_reg_write32(uint32_t offset, uint32_t value)
: {
: uint32_t mchbar = get_mchbar();
:
: if(mchbar)
: write32p(MCH_BASE_ADDRESS + offset, value);
: }
void ioc_reg_write32(uint32_t offset, uint32_t value) […]
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/27112608_74b7b193
PS17, Line 36: if(mchbar)
Please add a blank line above.
Ack
https://review.coreboot.org/c/coreboot/+/63198/comment/82a05d3a_5dc0593b
PS17, Line 44: data32 = ioc_reg_read32(offset);
Ditto.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I768027c2ca78310c03845f70f17df19dc8cd0982
Gerrit-Change-Number: 63198
Gerrit-PatchSet: 17
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Tue, 19 Apr 2022 03:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment