build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21107 )
Change subject: sb,soc/intel: Fix flashconsole on older platforms ......................................................................
Patch Set 15:
(5 comments)
https://review.coreboot.org/#/c/21107/15/src/soc/intel/fsp_broadwell_de/spi.... File src/soc/intel/fsp_broadwell_de/spi.c:
https://review.coreboot.org/#/c/21107/15/src/soc/intel/fsp_broadwell_de/spi.... PS15, Line 77: unsigned databytes; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/21107/15/src/soc/intel/fsp_broadwell_de/spi.... PS15, Line 284: static inline void spi_use_out(spi_transaction *trans, unsigned bytes) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/21107/15/src/soc/intel/fsp_broadwell_de/spi.... PS15, Line 290: static inline void spi_use_in(spi_transaction *trans, unsigned bytes) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/21107/15/src/soc/intel/fsp_broadwell_de/spi.... PS15, Line 345: } else { else is not generally useful after a break or return
https://review.coreboot.org/#/c/21107/15/src/soc/intel/fsp_broadwell_de/spi.... PS15, Line 399: printk(BIOS_DEBUG, "Unrecognized SPI transaction type %#x\n", trans->type); line over 80 characters
-
build bot (Jenkins) (Code Review)