[M] Change in coreboot[master]: util/cbfstool: Add a new mechanism to provide a memory mapped
Attention is currently required from: Nico Huber, Julius Werner, Maximilian Brune.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped ......................................................................
Patch Set 4:
(5 comments)
File util/cbfstool/cbfstool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161857): https://review.coreboot.org/c/coreboot/+/68160/comment/67957c20_8fa251e3 PS4, Line 395: * Default decode window lives just below 4G boundary in host space and maps up to a line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161857): https://review.coreboot.org/c/coreboot/+/68160/comment/5a6233e8_404f4cd5 PS4, Line 396: * maximum of 16MiB. If the window is smaller than 16MiB, the SPI flash window is mapped line length of 104 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161857): https://review.coreboot.org/c/coreboot/+/68160/comment/28a0209c_a732b52e PS4, Line 399: add_mmap_window(std_window_flash_offset, DEFAULT_DECODE_WINDOW_TOP - std_window_size, std_window_size); line length of 119 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161857): https://review.coreboot.org/c/coreboot/+/68160/comment/6afb4b14_3d538079 PS4, Line 408: ERROR("Flash space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 135 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161857): https://review.coreboot.org/c/coreboot/+/68160/comment/5f996b20_722a94b8 PS4, Line 418: ERROR("Host space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 134 exceeds 96 columns
-
build bot (Jenkins) (Code Review)