Attention is currently required from: Patrick Rudolph, Paul Menzel, King Sumo. Dun Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57296 )
Change subject: util/cbftool: Fix the bug in parsing Uefipayload with extended header ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57296/comment/e3241dbf_a739d835 PS3, Line 7: Fix the bug
Fix bug
Done
https://review.coreboot.org/c/coreboot/+/57296/comment/7442efce_874bbcb3 PS3, Line 7: Uefipayload
UefiPayload
Done
https://review.coreboot.org/c/coreboot/+/57296/comment/6cc68705_d815461a PS3, Line 7: cbftool
cbfstool
Done
https://review.coreboot.org/c/coreboot/+/57296/comment/72618e39_a7dced95 PS3, Line 9: The patch is to fix "Not a usable UEFI firmware volume" issue when : creating CBFS/flash image.
Is that documented somewhere? Please add a reference, or elaborate how to reproduce this. […]
Done
https://review.coreboot.org/c/coreboot/+/57296/comment/0267f3de_7fcb50a5 PS3, Line 10: This issue is caused by adding FvNameGuid : in UefiPayloadEntry.fdf in EDKII. There is an ext header between header : of Fv and header of PayloadEntry in Fv with FvNameGuid. The ext header : causes the UefiPayloadEntry to be found incorrectly when parsing Fv.
Please mention that in the commit message.
Done
https://review.coreboot.org/c/coreboot/+/57296/comment/23ac070a_547648e7 PS3, Line 14:
Please add the link and offending EDK2 commit hash to the commit message as well.
Done
Patchset:
PS4: Thanks. The commit hash in edk2 and bugzila link have been added in the commit message.