EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32265
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
mb/google/hatch: Restore Goodix Touch Screen
Restore Goodix devicetree config because of the missing when moving to override.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32265/1
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 7d668fe..b4cd241 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -68,18 +68,18 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end - chip drivers/i2c/hid - register "generic.hid" = ""GDIX0000"" - register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" - register "generic.probed" = "1" - register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "30" - register "generic.reset_off_delay_ms" = "3" - register "generic.has_power_resource" = "1" - register "hid_desc_reg_offset" = "0x01" - device i2c 5d on end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D15)" + register "generic.enable_delay_ms" = "30" + register "generic.enable_off_delay_ms" = "3" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end end end # I2C #1 device pci 15.2 on diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb index caa80a5..3242eb1 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb @@ -53,18 +53,18 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end - chip drivers/i2c/hid - register "generic.hid" = ""GDIX0000"" - register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" - register "generic.probed" = "1" - register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "30" - register "generic.reset_off_delay_ms" = "3" - register "generic.has_power_resource" = "1" - register "hid_desc_reg_offset" = "0x01" - device i2c 5d on end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D15)" + register "generic.enable_delay_ms" = "30" + register "generic.enable_off_delay_ms" = "3" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end end end # I2C #1 device pci 15.2 on
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32265
to look at the new patch set (#2).
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
mb/google/hatch: Restore Goodix Touch Screen
Restore Goodix devicetree config because of the missing when moving to override.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32265/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 2:
(2 comments)
What commit does this fix?
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG@9 PS2, Line 9: Restore Goodix devicetree config because of the : missing when moving to override. Please use the fully allowed text width.
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG@10 PS2, Line 10: missing Missing what?
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32265
to look at the new patch set (#3).
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
mb/google/hatch: Restore Goodix Touch Screen
Restore Goodix devicetree config because of the missing Goodix config when moving to overridetree.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32265/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG@9 PS2, Line 9: Restore Goodix devicetree config because of the : missing when moving to override.
Please use the fully allowed text width.
Ack
https://review.coreboot.org/#/c/32265/2//COMMIT_MSG@10 PS2, Line 10: missing
Missing what?
Ack
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 3:
Patch Set 2:
(2 comments)
What commit does this fix?
Fix the mistake on the https://review.coreboot.org/c/coreboot/+/32138, that missing copy goodix setting as well.
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32265
to look at the new patch set (#4).
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
mb/google/hatch: Restore Goodix Touch Screen
Restore Goodix devicetree config because of the missing Goodix config when moving from baseboard devicetree to board level overridetree.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32265/4
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 4:
Patch Set 2:
(2 comments)
What commit does this fix?
I made the comment more clear.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 61: enable_gpio reset_gpio?
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 63: nable reset
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 64: enable_ reset
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 71: drivers/generic/gpio_keys Not for this change, but this should be moved to 15.1 as well.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 4:
Patch Set 4:
(1 comment)
Okay, I can put together.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 4:
Patch Set 4:
(3 comments)
It’s weird. Enable can work as well,but reset is correct.
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32265
to look at the new patch set (#5).
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
mb/google/hatch: Restore Goodix Touch Screen
Restore Goodix devicetree config because of the missing Goodix config when moving from baseboard devicetree to board level overridetree.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 30 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32265/5
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 61: enable_gpio
reset_gpio?
Done
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 63: nable
reset
Done
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 64: enable_
reset
Done
https://review.coreboot.org/#/c/32265/4/src/mainboard/google/hatch/variants/... PS4, Line 71: drivers/generic/gpio_keys
Not for this change, but this should be moved to 15.1 as well.
I turn off I2C #2 as well.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32265/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32265/5//COMMIT_MSG@12 PS5, Line 12: It would be good to mention that the gpio_keys was moved to I2C1
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32265
to look at the new patch set (#6).
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
mb/google/hatch: Restore Goodix Touch Screen
Restore Goodix devicetree config because of the missing Goodix config when moving from baseboard devicetree to board level overridetree. And move PENH from I2C#2 to I2C#1.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 30 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32265/6
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32265/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32265/5//COMMIT_MSG@12 PS5, Line 12:
It would be good to mention that the gpio_keys was moved to I2C1
Should I add in title? or that's ok?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
Patch Set 6: Code-Review+2
Shelley Chen has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32265 )
Change subject: mb/google/hatch: Restore Goodix Touch Screen ......................................................................
mb/google/hatch: Restore Goodix Touch Screen
Restore Goodix devicetree config because of the missing Goodix config when moving from baseboard devicetree to board level overridetree. And move PENH from I2C#2 to I2C#1.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ic028c5d7b687a069d7f0510897bea91dca58e91f Reviewed-on: https://review.coreboot.org/c/coreboot/+/32265 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 30 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 5492379..22a0947 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -68,8 +68,19 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end - end # I2C #1 - device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "30" + register "generic.reset_off_delay_ms" = "3" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_A8)" @@ -79,7 +90,8 @@ register "key.label" = ""pen_eject"" device generic 0 on end end - end # I2C #2 + end # I2C #1 + device pci 15.2 off end # I2C #2 device pci 15.3 on chip drivers/i2c/sx9310 register "desc" = ""SAR Proximity Sensor"" diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb index dad372f..5bcb67e 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb @@ -53,8 +53,19 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end - end # I2C #1 - device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "30" + register "generic.reset_off_delay_ms" = "3" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_A8)" @@ -64,7 +75,8 @@ register "key.label" = ""pen_eject"" device generic 0 on end end - end # I2C #2 + end # I2C #1 + device pci 15.2 off end # I2C #2 device pci 15.3 on chip drivers/i2c/sx9310 register "desc" = ""SAR Proximity Sensor""
-
EricR Lai (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)
-
Shelley Chen (Code Review)