Attention is currently required from: Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Arthur Heymans, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52788 )
Change subject: soc/intel: Don't select VBOOT_SEPARATE_VERSTAGE
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
Seems okay to me. My understanding is that we use VBOOT_SEPARATE_VERSTAGE in a couple of scenarios: […]
+1 to all Furquan said. Linking into bootblock should be more efficient on XIP devices with no other restrictions.
Have you actually tested this on a board? I seem to recall that once upon a time I found this broken on x86. Don't remember any details though, may well be fixed at this point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e02961183b5bcc37365458a3b10342e5bc2b525
Gerrit-Change-Number: 52788
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 04 May 2021 00:53:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment