Change in coreboot[master]: Documentation: Add section about 'hidden' devices to 4.13 release notes
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Documentation: Add section about 'hidden' devices to 4.13 release notes
CB:41384 added some new functionality to devicetree files ("hidden PCI devices"). It's a decent enough semantic change that it should be added to the release notes for the 4.13 release.
Change-Id: I52969f63dbc492afd32279176cbcfc2b76d7ac33 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/41563/1
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index 94e93bb..0175250 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -13,4 +13,17 @@ Significant changes -------------------
-### Add significant changes here +### Hidden PCI devices + +This new functionality takes advantage of the existing 'hidden' keyword in the +devicetree. Since no existing boards were using the keyword, its usage was +repurposed to make dealing with some unique PCI devices easier. The particular +case here is Intel's PMC (Power Management Controller). During the FSP-S run, +the PMC device is made hidden, meaning that its config space looks as if there +is no device there (Vendor ID reads as 0xFFFF_FFFF). However, the device does +have fixed resources, both MMIO and I/O. These were previously recorded in +different places (MMIO was typically an SA fixed resource, and I/O was treated +as an LPC resource). With this change, when a device in the tree is marked as +'hidden', it is not probed (`pci_probe_dev()`) but rather assumed to exist so +that its resources can be placed in a more natural location. This also adds the +ability for the device to participate in SSDT generation.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41563/1/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/41563/1/Documentation/releases/core... PS1, Line 16: ### Add significant changes here I'm not sure if this line is of any value. If you think that it is, please keep it at the end of the file. Otherwise I guess I'll keep it out with the next version, too.
Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Duncan Laurie, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41563
to look at the new patch set (#2).
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Documentation: Add section about 'hidden' devices to 4.13 release notes
CB:41384 added some new functionality to devicetree files ("hidden PCI devices"). It's a decent enough semantic change that it should be added to the release notes for the 4.13 release.
Change-Id: I52969f63dbc492afd32279176cbcfc2b76d7ac33 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/41563/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41563/1/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/41563/1/Documentation/releases/core... PS1, Line 16: ### Add significant changes here
I'm not sure if this line is of any value. […]
It's good as a reminder to use ### for the header line 😊 I'll leave it in.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41563/1/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/41563/1/Documentation/releases/core... PS1, Line 16: ### Add significant changes here
It's good as a reminder to use ### for the header line 😊 I'll leave it in.
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2:
a
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41563/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41563/2//COMMIT_MSG@9 PS2, Line 9: CB:41384 added some new functionality to devicetree files ("hidden PCI Please use (maybe in addition) git commit hashes, so the git tools can be directly used.
https://review.coreboot.org/c/coreboot/+/41563/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/41563/2/Documentation/releases/core... PS2, Line 22: the PMC device is made hidden, meaning that its config space looks as if there Wasn’t it intended for minimal ramstage or so?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41563/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41563/2//COMMIT_MSG@9 PS2, Line 9: CB:41384 added some new functionality to devicetree files ("hidden PCI
Please use (maybe in addition) git commit hashes, so the git tools can be directly used.
Ack
https://review.coreboot.org/c/coreboot/+/41563/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/41563/2/Documentation/releases/core... PS2, Line 22: the PMC device is made hidden, meaning that its config space looks as if there
Wasn’t it intended for minimal ramstage or so?
Sorry, I don't understand what you mean?
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Duncan Laurie, Angel Pons, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41563
to look at the new patch set (#3).
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Documentation: Add section about 'hidden' devices to 4.13 release notes
CB:41384 (SHA dbcf7b16219df0c04401b8fcd6a780174a7df305) added some new functionality to devicetree files ("hidden PCI devices"). It's a decent enough semantic change that it should be added to the release notes for the 4.13 release.
Change-Id: I52969f63dbc492afd32279176cbcfc2b76d7ac33 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/41563/3
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41563/2/Documentation/releases/core... File Documentation/releases/coreboot-4.13-relnotes.md:
https://review.coreboot.org/c/coreboot/+/41563/2/Documentation/releases/core... PS2, Line 22: the PMC device is made hidden, meaning that its config space looks as if there
Sorry, I don't understand what you mean?
Paul, your question was pertaining to CONFIG(MINIMAL_PCI_SCANNING) and 'mandatory' keyword in devicetree.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 3: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Documentation: Add section about 'hidden' devices to 4.13 release notes
CB:41384 (SHA dbcf7b16219df0c04401b8fcd6a780174a7df305) added some new functionality to devicetree files ("hidden PCI devices"). It's a decent enough semantic change that it should be added to the release notes for the 4.13 release.
Change-Id: I52969f63dbc492afd32279176cbcfc2b76d7ac33 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/41563 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 15 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index 94e93bb..1d8839f 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -13,4 +13,19 @@ Significant changes -------------------
+### Hidden PCI devices + +This new functionality takes advantage of the existing 'hidden' keyword in the +devicetree. Since no existing boards were using the keyword, its usage was +repurposed to make dealing with some unique PCI devices easier. The particular +case here is Intel's PMC (Power Management Controller). During the FSP-S run, +the PMC device is made hidden, meaning that its config space looks as if there +is no device there (Vendor ID reads as 0xFFFF_FFFF). However, the device does +have fixed resources, both MMIO and I/O. These were previously recorded in +different places (MMIO was typically an SA fixed resource, and I/O was treated +as an LPC resource). With this change, when a device in the tree is marked as +'hidden', it is not probed (`pci_probe_dev()`) but rather assumed to exist so +that its resources can be placed in a more natural location. This also adds the +ability for the device to participate in SSDT generation. + ### Add significant changes here
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41563 )
Change subject: Documentation: Add section about 'hidden' devices to 4.13 release notes ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4937 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4936 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4935 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4934
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)