Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34679 )
Change subject: soc/fsp_broadwell_de: Implement SMBus read/write over IMC
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34679/4/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/smbus-imc.c:
https://review.coreboot.org/c/coreboot/+/34679/4/src/soc/intel/fsp_broadwell...
PS4, Line 24: return 0
aren't we returning the word data on success, 0 on failure?
https://review.coreboot.org/c/coreboot/+/34679/4/src/soc/intel/fsp_broadwell...
PS4, Line 36:
: /* read byte, return 0 on success */
aren't we returning the byte data on success, 0 on failure?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34679
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f5993dc795badf72751a4e6c9d974119a653e30
Gerrit-Change-Number: 34679
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 04:39:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment