Attention is currently required from: Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63861 )
Change subject: soc/intel/elkhartlake: Implement TSN GbE driver ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/63861/comment/ef73d16e_75853e0d PS2, Line 240: TSN_GBE_DRIVER Since this would be an elkhart lake spcific driver should we name it EHL_TSN_DRIVER?
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63861/comment/c5cbe5f0_e8e15f28 PS2, Line 15: if (!io_mem_base) { : printk(BIOS_ERR, "TSN GbE: Error can't find I/O MEM resource\n"); : return; : } This check is not needed here as it is already done in find_resource() for you. and even more, find_resource() will die() if the resource is missing. So you will never reach this code here and therefore can remove it completely.