Attention is currently required from: Furquan Shaikh, zanxi chen, Henry Sun, Paul Menzel, Tao Xia, Karthikeyan Ramasubramanian.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54249 )
Change subject: mb/google/dedede/var/blipper: Configure I2C times for touchpad/touchpanel/codec
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54249/comment/521b3b50_d2368970
PS3, Line 15: audio codec RT5682: 385 kHz
Hi Paul, […]
Paul is asking what was the observed frequency before this patch is introduced. If you have that info, then please add that in the commit message.
File src/mainboard/google/dedede/variants/blipper/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/54249/comment/58eba82e_5180654f
PS2, Line 24: .speed_config[0] = {
: .speed = I2C_SPEED_FAST,
: .scl_lcnt = 190,
: .scl_hcnt = 100,
: .sda_hold = 40,
: }
I have tried to replace the lcnt and hcnt with the measured rise and fall time, but the frequency wi […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54249
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8438e37be49f8a74f53fd8460110dac1a3f06993
Gerrit-Change-Number: 54249
Gerrit-PatchSet: 4
Gerrit-Owner: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ginger Zhang
zhangqingchun@huaqin.corp-partner.google.com
Gerrit-CC: Krystal Han
hanlijing@huaqin.corp-partner.google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-CC: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 05:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment