Attention is currently required from: Lance Zhao, Tarun Tuli, Martin L Roth, Subrata Banik, Paul Menzel, Tim Wawrzynczak, Ron Lee, Kane Chen.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71924 )
Change subject: drivers/usb/acpi: Add USB _DSM method to enable/disable USB LPM per port
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS5:
@Kapil, can u please pick this ?
Verified this on Taniks.
I can see the newly added _DSM for `USB3 Type-C Port C1 (DB)` where `register "usb_lpm_incapable" = "true"` was added.
```
Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method
{
ToBuffer (Arg0, Local0)
If ((Local0 == ToUUID ("ce2ee385-00e6-48cb-9f05-2edb927c4899") /* USB Controller */))
{
ToInteger (Arg2, Local1)
If ((Local1 == Zero))
{
Return (Buffer (One)
{
0x21 // !
})
}
If ((Local1 == One)){}
If ((Local1 == 0x02)){}
If ((Local1 == 0x03)){}
If ((Local1 == 0x04)){}
If ((Local1 == 0x05))
{
Return (0x01)
}
Return (Buffer (One)
{
0x00 // .
})
}
Return (Buffer (One)
{
0x00 // .
})
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffb2498e26352a3f120c097c50587324e311e8ba
Gerrit-Change-Number: 71924
Gerrit-PatchSet: 6
Gerrit-Owner: Ron Lee
ron.lee@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Ron Lee
ron.lee@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Mon, 16 Jan 2023 15:19:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment