Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50451 )
Change subject: soc/amd/cezanne: Add PCI IRQ Router definitions ......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/50451/comment/35cf608c_dfdcad88 PS1, Line 30: select SOC_AMD_COMMON_BLOCK_PCI_MMCONF you can drop this, since SOC_AMD_COMMON_BLOCK_PCI already selects SOC_AMD_COMMON_BLOCK_PCI_MMCONF
File src/soc/amd/cezanne/include/soc/amd_pci_int_defs.h:
https://review.coreboot.org/c/coreboot/+/50451/comment/bafae8c0_6ba2e0d5 PS1, Line 61: #define PIRQ_UART2 0x78 /* UART2 */ : #define PIRQ_UART3 0x79 /* UART3 */ without having verified this, this smells wrong. not sure if the documentation fixes in area around that uarts are already in a ppr release
-
Felix Held (Code Review)