Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Yidi Lin, Yu-Ping Wu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email )
Change subject: google/*: Clean up Kconfg board selection for Google MTK boards
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/asurada/Kconfig:
https://review.coreboot.org/c/coreboot/+/79063/comment/da76adaa_49f5ab34 :
PS1, Line 11: config BOARD_SPECIFIC_OPTIONS
That's a separate discussion we can have if you want, but personally I think things are ordered bett […]
Order is a very good argument. Note that I just wanted to point out that
other people may want to discuss this. Maybe wait a little if somebody else
chimes in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79063?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a
Gerrit-Change-Number: 79063
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 16 Nov 2023 12:33:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment