Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Shunxi Zhang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email )
Change subject: soc/mediatek/mt8196: Add RTC driver
......................................................................
Patch Set 11: Code-Review+1
(3 comments)
File src/soc/mediatek/mt8196/mt6685_rtc.c:
https://review.coreboot.org/c/coreboot/+/85978/comment/53870936_7f2eb967?usp... :
PS10, Line 13: #include <soc/mt6685.h>
remove
will update
https://review.coreboot.org/c/coreboot/+/85978/comment/3818a9bf_8ca49673?usp... :
PS10, Line 14: #include <soc/pmif.h>
: #include <soc/spmi.h>
Do we still need these two headers after using mt6685 API ?
will update
https://review.coreboot.org/c/coreboot/+/85978/comment/3bbffc1a_160b6ba7?usp... :
PS10, Line 90: config_interface(RG_FQMTR_TCKSEL, FQMTR_DCXO26M_EN | measure_src,
: RG_FQMTR_TCKSEL_MASK, RG_FQMTR_TCKSEL_SHIFT);
`config_interface(0x546, (1ul << (4)) | measure_src, 0x7, 0);` […]
will update
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85978?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dd337eaa3eed3012ddea300f7e04f2b63fb2daa
Gerrit-Change-Number: 85978
Gerrit-PatchSet: 11
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shunxi Zhang
ot_shunxi.zhang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 22 Jan 2025 10:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yidi Lin
yidilin@google.com