Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol
postcar_commit_mtrrs() isn't used outside the postcar_loader compilation unit. Make it static to reduce API surface area.
Change-Id: If07f34467941d00de731489867e485cfff80ea63 Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/include/arch/romstage.h M src/arch/x86/postcar_loader.c 2 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35130/1
diff --git a/src/arch/x86/include/arch/romstage.h b/src/arch/x86/include/arch/romstage.h index 7816a7c..2ac2258 100644 --- a/src/arch/x86/include/arch/romstage.h +++ b/src/arch/x86/include/arch/romstage.h @@ -58,12 +58,6 @@ void postcar_frame_common_mtrrs(struct postcar_frame *pcf);
/* - * Push used MTRR and Max MTRRs on to the stack - * and return pointer to stack top. - */ -void *postcar_commit_mtrrs(struct postcar_frame *pcf); - -/* * fill_postcar_frame() is called after raminit completes and right before * calling run_postcar_phase(). Implementation should call postcar_frame_add_mtrr() * to tag memory ranges as cacheable to speed up execution of postcar and diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index 4a7d549..b9487a7 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -147,7 +147,7 @@ /* We do not return here. */ }
-void *postcar_commit_mtrrs(struct postcar_frame *pcf) +static void postcar_commit_mtrrs(struct postcar_frame *pcf) { /* * Place the number of used variable MTRRs on stack then max number
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35130/1/src/arch/x86/postcar_loader... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/35130/1/src/arch/x86/postcar_loader... PS1, Line 158: return (void *) pcf->stack; Need to remove this.
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35130
to look at the new patch set (#2).
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol
postcar_commit_mtrrs() isn't used outside the postcar_loader compilation unit. Make it static to reduce API surface area. Additionally the return value was not being utilized. Modify the return type to be void to align with the current usage.
Change-Id: If07f34467941d00de731489867e485cfff80ea63 Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/include/arch/romstage.h M src/arch/x86/postcar_loader.c 2 files changed, 1 insertion(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35130/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
Patch Set 2: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35130/1/src/arch/x86/postcar_loader... File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/c/coreboot/+/35130/1/src/arch/x86/postcar_loader... PS1, Line 158: return (void *) pcf->stack;
Need to remove this.
Done
Aaron Durbin has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol
postcar_commit_mtrrs() isn't used outside the postcar_loader compilation unit. Make it static to reduce API surface area. Additionally the return value was not being utilized. Modify the return type to be void to align with the current usage.
Change-Id: If07f34467941d00de731489867e485cfff80ea63 Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/35130 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/x86/include/arch/romstage.h M src/arch/x86/postcar_loader.c 2 files changed, 1 insertion(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved
diff --git a/src/arch/x86/include/arch/romstage.h b/src/arch/x86/include/arch/romstage.h index 7816a7c..2ac2258 100644 --- a/src/arch/x86/include/arch/romstage.h +++ b/src/arch/x86/include/arch/romstage.h @@ -58,12 +58,6 @@ void postcar_frame_common_mtrrs(struct postcar_frame *pcf);
/* - * Push used MTRR and Max MTRRs on to the stack - * and return pointer to stack top. - */ -void *postcar_commit_mtrrs(struct postcar_frame *pcf); - -/* * fill_postcar_frame() is called after raminit completes and right before * calling run_postcar_phase(). Implementation should call postcar_frame_add_mtrr() * to tag memory ranges as cacheable to speed up execution of postcar and diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index 4a7d549..6a7d389 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -147,7 +147,7 @@ /* We do not return here. */ }
-void *postcar_commit_mtrrs(struct postcar_frame *pcf) +static void postcar_commit_mtrrs(struct postcar_frame *pcf) { /* * Place the number of used variable MTRRs on stack then max number @@ -155,7 +155,6 @@ */ stack_push(pcf, pcf->num_var_mtrrs); stack_push(pcf, pcf->max_var_mtrrs); - return (void *) pcf->stack; }
static void finalize_load(uintptr_t *stack_top_ptr, uintptr_t stack_top)
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)
-
Paul Menzel (Code Review)