build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28096 )
Change subject: riscv: add support for supervisor binary interface (SBI) ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c File src/arch/riscv/sbi.c:
https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@29 PS5, Line 29: die("Please implement the "set_msip" function on your platform."); Prefer using '"%s...", __func__' to using 'set_msip', this function's name, in a string
https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@83 PS5, Line 83: tf->gpr[10] = sbi_set_timer(tf->gpr[10] + ((uint64_t)tf->gpr[11] << 32)); line over 80 characters
https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@104 PS5, Line 104: tf->gpr[10] = send_ipi((uintptr_t *)tf->gpr[10], IPI_SFENCE_VMA); line over 80 characters
https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@107 PS5, Line 107: tf->gpr[10] = send_ipi((uintptr_t *)tf->gpr[10], IPI_SFENCE_VMA_ASID); line over 80 characters
-
build bot (Jenkins) (Code Review)