Attention is currently required from: Felix Singer, Jon Murphy, Karthik Ramasubramanian, Martin L Roth.
Raul Rangel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )
Change subject: util/crossgcc: Add libstdcxx target ......................................................................
Patch Set 8:
(7 comments)
Patchset:
PS5:
My concern is that what we have on upstream blows up too much. […]
Honestly I feel like any modular solution we come up with is going to be more complex than this 48 line diff.
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/85275/comment/572d1362_90901043?usp... : PS8, Line 1: sh Ugh POSIX `sh`... why not bash?
https://review.coreboot.org/c/coreboot/+/85275/comment/eea4e8cb_b47a37a3?usp... : PS8, Line 783: declare `local`?
https://review.coreboot.org/c/coreboot/+/85275/comment/4a86a048_0891770a?usp... : PS8, Line 784: @ POSIX `sh` doesn't actually have arrays AFAIK.
https://review.coreboot.org/c/coreboot/+/85275/comment/afc62b34_c285f9d8?usp... : PS8, Line 787: rm -f "gcc/$TARGETARCH/$GCC_VERSION" && \ : ln -s "$DESTDIR$TARGETDIR/$TARGETARCH/bin" "gcc/$TARGETARCH/$GCC_VERSION" && \ : $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-gcc && \ : $MAKE install-gcc DESTDIR="$DESTDIR" || touch .failed : : if [ ! -f .failed ] && [ "$(echo $TARGETARCH | grep -c -- -mingw32)" -eq 0 ]; then : # shellcheck disable=SC2086 : $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-target-libgcc && \ : $MAKE install-target-libgcc DESTDIR=$DESTDIR || touch .failed : fi Move this function below `configure_GCC` so that the diff shows that this wasn't changed.
https://review.coreboot.org/c/coreboot/+/85275/comment/6e6c991f_7991344b?usp... : PS8, Line 858: [@] Not an array
https://review.coreboot.org/c/coreboot/+/85275/comment/8c867bff_50f85096?usp... : PS8, Line 862: LIBSTDCXX_INCLUDE_PATH Maybe verify that `LIBSTDCXX_INCLUDE_PATH` isn't empty?
-
Raul Rangel (Code Review)