Attention is currently required from: Eric Lai.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74281 )
Change subject: mb/google/myst: Store XHCI PCI resources
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/myst/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74281/comment/840de249_3d3a40af
PS1, Line 100: soc_xhci_store_resources(slots, size);
Just curious, I trace the code a little bit. […]
Good question. I admittedly was carrying the implementation forward, but see now that it's a copy/paste across all mainboards. I don't see a reason not to put it in the common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I608d51f438681ac529323c23cc707845a3d609d1
Gerrit-Change-Number: 74281
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 07 Apr 2023 03:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment