Attention is currently required from: Patrick Rudolph, Simon Chou, TimLiu-SMCI, Johnny Lin, Christian Walter, Angel Pons, Arthur Heymans, Jian-Ming Wang, Tim Chu, Shelly Chang.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71958 )
Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS8:
The diff between the original nb_acpi.c and the new uncore_acpi.c is not shown. I wonder if we did "git mv"?
File src/soc/intel/xeon_sp/uncore_acpi.c:
https://review.coreboot.org/c/coreboot/+/71958/comment/f1fb46f4_e9a218ba
PS2, Line 147: pds.
Where does it come from?
pds is short for Proximity Domains. It is needed for CXL capable system, where proximity domains include both (traditional) processor domains and CXL domains.
pds is a global variable, defined in uncore.c .
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf
Gerrit-Change-Number: 71958
Gerrit-PatchSet: 8
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Fri, 03 Feb 2023 06:00:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment