Attention is currently required from: Vince Liu, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87038?usp=email )
Change subject: mb/google/skywalker: Add DRAM calibration init entry
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/skywalker/romstage.c:
https://review.coreboot.org/c/coreboot/+/87038/comment/c9f26b2c_5fa0eea9?usp... :
PS1, Line 8: /* TODO: add romstage main function */
remove
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87038?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iabdcabefc77a262c548019e801daf5b269eaa97a
Gerrit-Change-Number: 87038
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 07 Apr 2025 14:18:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes