Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39739 )
Change subject: mb/gigabyte/ga-h61*/devicetree.cb: Add missing IRQ ......................................................................
mb/gigabyte/ga-h61*/devicetree.cb: Add missing IRQ
IRQ 0x70 was not declared for device 2e.7, and coreboot whined about it.
Change-Id: If40aa390722cf253169003129b31f20543fde5dd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39739/1
diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb index de9c213..b25bba6 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb @@ -76,6 +76,7 @@ io 0x60 = 0x0000 io 0x62 = 0x0a00 io 0x64 = 0x0000 + irq 0x70 = 0x00 irq 0x73 = 0x00 irq 0xc1 = 0x37 irq 0xcb = 0x00 diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb index c898fad..08abc3e 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb @@ -89,6 +89,7 @@ io 0x60 = 0x0000 io 0x62 = 0x0a00 io 0x64 = 0x0000 + irq 0x70 = 0x00 irq 0xcb = 0x00 irq 0xf1 = 0x40 end diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb index ad3a35c..cbd0ee6 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb @@ -80,6 +80,7 @@ io 0x60 = 0x0000 io 0x62 = 0x0a00 io 0x64 = 0x0000 + irq 0x70 = 0x00 irq 0x73 = 0x00 irq 0xcb = 0x00 irq 0xf0 = 0x10
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39739
to look at the new patch set (#2).
Change subject: mb/gigabyte/ga-h61m-*/devicetree.cb: Add missing IRQ ......................................................................
mb/gigabyte/ga-h61m-*/devicetree.cb: Add missing IRQ
IRQ 0x70 was not declared for device 2e.7, and coreboot whined about it.
Change-Id: If40aa390722cf253169003129b31f20543fde5dd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/39739/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39739 )
Change subject: mb/gigabyte/ga-h61m-*/devicetree.cb: Add missing IRQ ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39739 )
Change subject: mb/gigabyte/ga-h61m-*/devicetree.cb: Add missing IRQ ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39739 )
Change subject: mb/gigabyte/ga-h61m-*/devicetree.cb: Add missing IRQ ......................................................................
mb/gigabyte/ga-h61m-*/devicetree.cb: Add missing IRQ
IRQ 0x70 was not declared for device 2e.7, and coreboot whined about it.
Change-Id: If40aa390722cf253169003129b31f20543fde5dd Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39739 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb 3 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb index de9c213..b25bba6 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb @@ -76,6 +76,7 @@ io 0x60 = 0x0000 io 0x62 = 0x0a00 io 0x64 = 0x0000 + irq 0x70 = 0x00 irq 0x73 = 0x00 irq 0xc1 = 0x37 irq 0xcb = 0x00 diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb index c898fad..08abc3e 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/devicetree.cb @@ -89,6 +89,7 @@ io 0x60 = 0x0000 io 0x62 = 0x0a00 io 0x64 = 0x0000 + irq 0x70 = 0x00 irq 0xcb = 0x00 irq 0xf1 = 0x40 end diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb index ad3a35c..cbd0ee6 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/devicetree.cb @@ -80,6 +80,7 @@ io 0x60 = 0x0000 io 0x62 = 0x0a00 io 0x64 = 0x0000 + irq 0x70 = 0x00 irq 0x73 = 0x00 irq 0xcb = 0x00 irq 0xf0 = 0x10
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)