Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79906?usp=email )
Change subject: [RFC] region: Allow region_end() to return 64-bit numbers ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79906/comment/ef4ebfa4_8e8a4dd5 : PS1, Line 9: We most likely operate on regions that end exactly at the 4GiB boundary
would it make sense to document that 64bit + overflow is still possible?
Well, the idea of the region_create() functions is to avoid overflows. I realized only later that region_end() still can overflow. This is most annoying, and only because region_end() doesn't return an inclusive value. I'd prefer to discuss the implementations further.
Maybe, if nobody objects, we could make region_end() return an inclusive offset. It's return value doesn't seem to be used much. My only concern right now is that it could confuse developers that are used to the current behaviour.