Attention is currently required from: Paul Menzel.
Kevin3 Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74889 )
Change subject: mb/google/dedede/var/boxy: Disable EXT_VR
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74889/comment/1a0159bb_d63fc804
PS4, Line 7: for boxy
Redundant as in prefix.
Done
https://review.coreboot.org/c/coreboot/+/74889/comment/5840aa8c_68cc9c9a
PS4, Line 9: Disable EXT_VR for boxy
Please add why it should be disabled.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74889
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6667e93de41e84f67363ab7554fe755fe50684a
Gerrit-Change-Number: 74889
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin3 Yang
kevin3.yang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 04 May 2023 01:07:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment