Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33770 )
Change subject: soc/amd/picasso: Update southbridge
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33770/4/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/33770/4/src/soc/amd/picasso/include...
PS4, Line 173: BIT(2)
Either this register is the same as last time, and it's actually a disable register or it's been updated. Either way, we should probably comment the enable value. If it's been changed, mention that it's opposite of stoney.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69dfc4a875006639aa330385680d150331840e40
Gerrit-Change-Number: 33770
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jul 2019 16:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment