Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84562?usp=email )
Change subject: Makefile.mk: Remove Wno-packed-not-aligned flag
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84562/comment/b939d92e_eb3df349?usp... :
PS10, Line 8:
`Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 035ee6a66836 ("Makefile.inc: disable warnings on unaligned struct members")'`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84562?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8759603ff7b2c75e4a863a25c796781544be14ed
Gerrit-Change-Number: 84562
Gerrit-PatchSet: 11
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 11 Nov 2024 02:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No