Change in coreboot[master]: soc/intel/xeon_sp: Remove superfluous printk

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

soc/intel/xeon_sp: Remove superfluous printk

This debug output is not very useful. If CONFIG_BOOTBLOCK_CONSOLE is
enabled there will already be something else printed on the console
before this.

Change-Id: I7c6013805497604bb6a42ed4f9fdc594a73c28f1
Signed-off-by: Arthur Heymans 
---
M src/soc/intel/xeon_sp/bootblock.c
1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/47739/1

diff --git a/src/soc/intel/xeon_sp/bootblock.c b/src/soc/intel/xeon_sp/bootblock.c
index baf5ab5..0b04f03 100644
--- a/src/soc/intel/xeon_sp/bootblock.c
+++ b/src/soc/intel/xeon_sp/bootblock.c
@@ -62,9 +62,6 @@

void bootblock_soc_init(void)
 {
-	if (CONFIG(BOOTBLOCK_CONSOLE))
-		printk(BIOS_DEBUG, "FSP TempRamInit successful...\n");
-
    if (assembly_timestamp > bootblock_timestamp)
    	printk(BIOS_WARNING, "Invalid initial timestamp detected\n");

[Arthur Heymans (Code Review)]

Hello Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47739

to look at the new patch set (#2).

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

soc/intel/xeon_sp: Remove superfluous printk

This debug output is not very useful. If CONFIG_BOOTBLOCK_CONSOLE is
enabled there will already be something else printed on the console
before this.

Change-Id: I7c6013805497604bb6a42ed4f9fdc594a73c28f1
Signed-off-by: Arthur Heymans 
---
M src/soc/intel/xeon_sp/bootblock.c
1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/47739/2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47739/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47739/2//COMMIT_MSG@11 
PS2, Line 11: before this.
Before this, but after FSP-T is finished? I think the idea is to see if FSP-T worked.

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

Patch Set 2: Code-Review+2

[Rocky Phagura (Code Review)]

Attention is currently required from: Arthur Heymans.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: 
This patch is ready for merge.

[Rocky Phagura (Code Review)]

Attention is currently required from: Arthur Heymans.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

Patchset:

PS2: 
Arthur,
This patch just needs you to resolve the comments and it should be ready for merge.

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47739/comment/e1f6f082_f289c7f5 
PS2, Line 11: before this.
> Before this, but after FSP-T is finished? I think the idea is to see if FSP-T worked.

So you have FSP-T -> console init with initial message -> this message. The initial console init message serves as a sufficient proxy to know if FSP-T failed.

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47739 )

Change subject: soc/intel/xeon_sp: Remove superfluous printk
......................................................................

soc/intel/xeon_sp: Remove superfluous printk

This debug output is not very useful. If CONFIG_BOOTBLOCK_CONSOLE is
enabled there will already be something else printed on the console
before this.

Change-Id: I7c6013805497604bb6a42ed4f9fdc594a73c28f1
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47739
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Frans Hendriks 
Reviewed-by: Rocky Phagura
---
M src/soc/intel/xeon_sp/bootblock.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Frans Hendriks: Looks good to me, approved
  Angel Pons: Looks good to me, approved
  Rocky Phagura: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/xeon_sp/bootblock.c b/src/soc/intel/xeon_sp/bootblock.c
index baf5ab5..0b04f03 100644
--- a/src/soc/intel/xeon_sp/bootblock.c
+++ b/src/soc/intel/xeon_sp/bootblock.c
@@ -62,9 +62,6 @@

void bootblock_soc_init(void)
 {
-	if (CONFIG(BOOTBLOCK_CONSOLE))
-		printk(BIOS_DEBUG, "FSP TempRamInit successful...\n");
-
    if (assembly_timestamp > bootblock_timestamp)
    	printk(BIOS_WARNING, "Invalid initial timestamp detected\n");