[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable

[Angel Pons (Code Review)]

Attention is currently required from: Sean Rhodes, Benjamin Doron, Maximilian Brune, Lean Sheng Tan.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )

Change subject: [RFC] drivers/option: Add option list in cbtable
......................................................................

Patch Set 3:

(2 comments)

File src/drivers/option/cfr.h:

https://review.coreboot.org/c/coreboot/+/74121/comment/4165b638_a86ed50d 
PS3, Line 133: 	/* CFR_OPT_NAME		opt_name */
             : 	/* CFR_UI_NAME		ui_name */
             : 	/* CFR_UI_HELPTEXT	ui_helptext (Optional) */
             :
> Nit: Use long comment like the other structs, a short comment above for `lb_cfr_enum_value`, and reo […]

Yes, will fix.

File src/drivers/option/cfr.c:

https://review.coreboot.org/c/coreboot/+/74121/comment/7c656da4_c6a882b7 
PS3, Line 103: option_id
> I know it's used in EDK2's HII backend as the "question" identifier. […]

It's not an index. This is meant to be used in the future for dynamic dependencies (e.g. grayout if, suppress if). The order of options is the order in which they appear in the CFR structures.