Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74399 )
Change subject: cpu,soc/intel: Separate single SSDT CPU entry ......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74399/comment/c55efc17_69da8d54 PS1, Line 390: const struct device *device,
unused?
Done
https://review.coreboot.org/c/coreboot/+/74399/comment/285ea19e_bb7d4c63 PS1, Line 422: generate_cpu_entry(device, cpu_id, core_id, num_virt);
Is it really okay that we use the BSP CPU to create also the AP CPU's entries on some platforms?
I guess it's fragile?
Well.. That sounds like a major rewrite if that has to change for some model.
-
Kyösti Mälkki (Code Review)