Attention is currently required from: Jason Glenesk, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50462 )
Change subject: soc/amd: factor out common SMM relocation code ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50462/comment/8697b1ea_fbc3f714 PS4, Line 9: cpu
optional: imo, just blocks/smm would be clear so it matches the Kconfig value. […]
for the tsc i got the request to put it in a sub-directory of soc/amd/common/blocks/cpu instead since it is part of the cpu block and the same is for smm, so i went the same route here and it's also consistent with the tsc. see https://review.coreboot.org/c/coreboot/+/48305/3#message-c8873cbcaa1adaa2a1c... and some earlier patch where Furquan had some comment about the folderstructure below soc/amd/common/block, but i don't find that comment right now. so i'd keep this as it is right now and when the bringup is done, i'm happy to discuss where which common code should live and move it around when necessary
-
Felix Held (Code Review)