[S] Change in coreboot[main]: mb/google/trulo/var/uldrenite: Add fw_config probe for Cellular - coreboot-gerrit

5 Feb 2025


      Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro.
Dtrain Hsu has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86255?usp=email )
Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for Cellular
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86255/comment/568f90f6_c60b630d?usp... :
PS2, Line 476: end
Should we also need to disable pcie_rp2 when CELLULAR_ABSENT?
probe DB_CELLULAR CELLULAR_RW350R
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86255?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib664f543c6012b44a0a604d0943416519d92a057
Gerrit-Change-Number: 86255
Gerrit-PatchSet: 2
Gerrit-Owner: John Su john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen jamie_chen@compal.corp-partner.google.com
Gerrit-Attention: Jayvik Desai jayvik@google.com
Gerrit-Attention: John Su john_su@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 05 Feb 2025 08:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes