Change in coreboot[master]: mb/google/brya: Add UsbTcPortEn in devicetree - coreboot-gerrit

6 Jul 2021


      Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56074 )
Change subject: mb/google/brya: Add UsbTcPortEn in devicetree
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/tcss.h:
https://review.coreboot.org/c/coreboot/+/56074/comment/3d9153ad_6c451d0f 
PS3, Line 97: 
            : #define TCSS_PORT_0	1
...
my only concern is common code is not to fill in with FSP UPD related macros. […]
#define TCSS_PORT(x)       BIT(x)??? You mean this way or? why enum?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe9d3a6d1d73cb37daae4a1ae49ee26abc43635b
Gerrit-Change-Number: 56074
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 06 Jul 2021 04:25:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment