Change in ...coreboot[master]: superio/nsc/pc87392: Remove unused early_serial

[Peter Lemenkov (Code Review)]

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31333

Change subject: superio/nsc/pc87392: Remove unused early_serial
......................................................................

superio/nsc/pc87392: Remove unused early_serial

Change-Id: I9437ee3f8830dc831aacfc62b9dd1943b73b98d4
Signed-off-by: Peter Lemenkov 
---
D src/superio/nsc/pc87392/early_serial.c
1 file changed, 0 insertions(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/31333/1

diff --git a/src/superio/nsc/pc87392/early_serial.c b/src/superio/nsc/pc87392/early_serial.c
deleted file mode 100644
index f8eb255..0000000
--- a/src/superio/nsc/pc87392/early_serial.c
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2011 Sven Schnelle 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#include <arch/io.h>
-#include "pc87392.h"
-
-static void pc87392_enable_serial(pnp_devfn_t dev, u16 iobase)
-{
-	pnp_set_logical_device(dev);
-	pnp_set_enable(dev, 0);
-	pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
-	pnp_set_enable(dev, 1);
-}

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31333 )

Change subject: superio/nsc/pc87392: Remove unused early_serial
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31333/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31333/1//COMMIT_MSG@7 
PS1, Line 7: unused
Why unused?

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31333 )

Change subject: superio/nsc/pc87392: Remove unused early_serial
......................................................................

Patch Set 1:

(1 comment)

please select SUPERIO_NSC_COMMON_PRE_RAM in the Kconfig option for this SIO

https://review.coreboot.org/#/c/31333/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31333/1//COMMIT_MSG@7 
PS1, Line 7: unused
> Why unused?

It wasn't hooked up in Makefile.inc

Change in ...coreboot[master]: superio/nsc/pc87392: Use common early_serial

[Peter Lemenkov (Code Review)]

Hello Felix Held, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31333

to look at the new patch set (#2).

Change subject: superio/nsc/pc87392: Use common early_serial
......................................................................

superio/nsc/pc87392: Use common early_serial

Change-Id: I9437ee3f8830dc831aacfc62b9dd1943b73b98d4
Signed-off-by: Peter Lemenkov 
---
M src/superio/nsc/pc87392/Kconfig
D src/superio/nsc/pc87392/early_serial.c
2 files changed, 1 insertion(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/31333/2

Change in ...coreboot[master]: superio/nsc/pc87392: Use common early_serial

[Peter Lemenkov (Code Review)]

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31333 )

Change subject: superio/nsc/pc87392: Use common early_serial
......................................................................

Patch Set 1:
> (1 comment)
>
> please select SUPERIO_NSC_COMMON_PRE_RAM in the Kconfig option for
> this SIO

Done!

Change in ...coreboot[master]: superio/nsc/pc87392: Use common early_serial

[Peter Lemenkov (Code Review)]

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31333 )

Change subject: superio/nsc/pc87392: Use common early_serial
......................................................................

Patch Set 2:
> (1 comment)

It wasn't mentioned in any makefile.

Anyway now it's handled in the same way as some other superio chips from this PR.

Change in ...coreboot[master]: superio/nsc/pc87392: Use common early_serial

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31333 )

Change subject: superio/nsc/pc87392: Use common early_serial
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: superio/nsc/pc87392: Use common early_serial

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31333 )

Change subject: superio/nsc/pc87392: Use common early_serial
......................................................................

superio/nsc/pc87392: Use common early_serial

Change-Id: I9437ee3f8830dc831aacfc62b9dd1943b73b98d4
Signed-off-by: Peter Lemenkov 
Reviewed-on: https://review.coreboot.org/c/31333
Reviewed-by: Felix Held 
Tested-by: build bot (Jenkins) 
---
M src/superio/nsc/pc87392/Kconfig
D src/superio/nsc/pc87392/early_serial.c
2 files changed, 1 insertion(+), 26 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/src/superio/nsc/pc87392/Kconfig b/src/superio/nsc/pc87392/Kconfig
index f0f6fd0..adff8df 100644
--- a/src/superio/nsc/pc87392/Kconfig
+++ b/src/superio/nsc/pc87392/Kconfig
@@ -15,3 +15,4 @@

config SUPERIO_NSC_PC87392
    bool
+	select SUPERIO_NSC_COMMON_PRE_RAM
diff --git a/src/superio/nsc/pc87392/early_serial.c b/src/superio/nsc/pc87392/early_serial.c
deleted file mode 100644
index f8eb255..0000000
--- a/src/superio/nsc/pc87392/early_serial.c
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2011 Sven Schnelle 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#include <arch/io.h>
-#include "pc87392.h"
-
-static void pc87392_enable_serial(pnp_devfn_t dev, u16 iobase)
-{
-	pnp_set_logical_device(dev);
-	pnp_set_enable(dev, 0);
-	pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
-	pnp_set_enable(dev, 1);
-}