Attention is currently required from: Angel Pons, Patrick Rudolph, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78090?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: sb/intel/common/spi: Fix I/O alignment
......................................................................
Patch Set 2:
(1 comment)
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/78090/comment/21726fd1_8cffda6b :
PS2, Line 96: uint8_t *control;
i'd suggest to add a comment here that it's an unaligned 16 bit register. at least for me that would make the related code less unexpected
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78090?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id05b1a080911b71b94ef781c6e26d98165f02f67
Gerrit-Change-Number: 78090
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 14:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment