Change in coreboot[master]: src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38200 )
Change subject: src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols ......................................................................
src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols
Some motherboards may have more than one VGA adapter - for example, there are versions of Lenovo G505S that have a discrete VGA adapter in addition to its' integrated VGA adapter which is a part of APU.
MULTIPLE_VGA_ADAPTERS Kconfig symbols, combined with other changes, will help to get a discrete VGA adapter working at these boards.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I03133a45f28251291008267e5c9b10f805c0003a --- M src/device/Kconfig 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38200/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index 0bd9fe1..979ad90 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -63,6 +63,11 @@ Selected by mainboards that implement support for `libgfxinit`. Usually this requires a list of ports to be probed for displays.
+config MAINBOARD_HAS_MULTIPLE_VGA_ADAPTERS + bool + help + Selected by mainboards that have or support multiple VGA adapters. + choice prompt "Graphics initialization" default NO_GFX_INIT if VGA_BIOS && PAYLOAD_SEABIOS @@ -261,8 +266,15 @@ Enable this option for a good compromise between security and speed.
config MULTIPLE_VGA_ADAPTERS + prompt "Multiple VGA Adapters" bool + depends on MAINBOARD_HAS_MULTIPLE_VGA_ADAPTERS default n + help + Some motherboards may have more than one VGA adapter - for example, + there are versions of Lenovo G505S that have a discrete VGA adapter + in addition to its' integrated VGA adapter which is a part of APU. + Enable this option to try to initialize this discrete VGA adapter.
menu "Display" depends on HAVE_VGA_TEXT_FRAMEBUFFER || HAVE_LINEAR_FRAMEBUFFER
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38200 )
Change subject: src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols ......................................................................
Patch Set 1:
Is this new work or old with a different Change-Id?
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38200 )
Change subject: src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols ......................................................................
Patch Set 1:
Patch Set 1:
Is this new work or old with a different Change-Id?
For an easier review I split an older CB:31450 to three smaller ones. I hope this time it won't be "just a rebase", and really serious to work on getting these patches merged with you help.
CB:38200 - src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols CB:38201 - lenovo/g505s: fix the VGA-related PCI resource allocation problems CB:38203 - lenovo/g505s: enable the discrete VGA adapter (depends on CB:38202)
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38200 )
Change subject: src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols ......................................................................
Abandoned
The wording was a bit misleading and not precise enough. Abandoned in favor of CB:57319
Mike Banon has restored this change. ( https://review.coreboot.org/c/coreboot/+/38200 )
Change subject: src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols ......................................................................
Restored
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38200 )
Change subject: src/device/Kconfig: introduce the MULTIPLE_VGA_ADAPTERS symbols ......................................................................
Abandoned
-
Kyösti Mälkki (Code Review) -
Mike Banon (Code Review)