Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49087 )
Change subject: cpu/intel/x/chip.h: Drop unused `disable_acpi` setting ......................................................................
cpu/intel/x/chip.h: Drop unused `disable_acpi` setting
It is not used anywhere. Drop it.
Change-Id: I92a72a46db237cf855491a664cdfadca34306f6c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/haswell/chip.h M src/cpu/intel/model_2065x/chip.h M src/cpu/intel/model_206ax/chip.h 3 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/49087/1
diff --git a/src/cpu/intel/haswell/chip.h b/src/cpu/intel/haswell/chip.h index 7d41461..6afed37 100644 --- a/src/cpu/intel/haswell/chip.h +++ b/src/cpu/intel/haswell/chip.h @@ -4,8 +4,6 @@ #define SPEEDSTEP_APIC_MAGIC 0xACAC
struct cpu_intel_haswell_config { - u8 disable_acpi; /* Do not generate CPU ACPI tables */ - int c1_battery; /* ACPI C1 on Battery Power */ int c2_battery; /* ACPI C2 on Battery Power */ int c3_battery; /* ACPI C3 on Battery Power */ diff --git a/src/cpu/intel/model_2065x/chip.h b/src/cpu/intel/model_2065x/chip.h index 21f75a3..d9b1057 100644 --- a/src/cpu/intel/model_2065x/chip.h +++ b/src/cpu/intel/model_2065x/chip.h @@ -4,8 +4,6 @@ #define SPEEDSTEP_APIC_MAGIC 0xACAC
struct cpu_intel_model_2065x_config { - u8 disable_acpi; /* Do not generate CPU ACPI tables */ - int c1_battery; /* ACPI C1 on Battery Power */ int c2_battery; /* ACPI C2 on Battery Power */ int c3_battery; /* ACPI C3 on Battery Power */ diff --git a/src/cpu/intel/model_206ax/chip.h b/src/cpu/intel/model_206ax/chip.h index 4e40830..a5a4312 100644 --- a/src/cpu/intel/model_206ax/chip.h +++ b/src/cpu/intel/model_206ax/chip.h @@ -4,8 +4,6 @@ #define SPEEDSTEP_APIC_MAGIC 0xACAC
struct cpu_intel_model_206ax_config { - u8 disable_acpi; /* Do not generate CPU ACPI tables */ - int c1_battery; /* ACPI C1 on Battery Power */ int c2_battery; /* ACPI C2 on Battery Power */ int c3_battery; /* ACPI C3 on Battery Power */
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49087 )
Change subject: cpu/intel/x/chip.h: Drop unused `disable_acpi` setting ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49087 )
Change subject: cpu/intel/x/chip.h: Drop unused `disable_acpi` setting ......................................................................
cpu/intel/x/chip.h: Drop unused `disable_acpi` setting
It is not used anywhere. Drop it.
Change-Id: I92a72a46db237cf855491a664cdfadca34306f6c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49087 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/haswell/chip.h M src/cpu/intel/model_2065x/chip.h M src/cpu/intel/model_206ax/chip.h 3 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/cpu/intel/haswell/chip.h b/src/cpu/intel/haswell/chip.h index 7d41461..6afed37 100644 --- a/src/cpu/intel/haswell/chip.h +++ b/src/cpu/intel/haswell/chip.h @@ -4,8 +4,6 @@ #define SPEEDSTEP_APIC_MAGIC 0xACAC
struct cpu_intel_haswell_config { - u8 disable_acpi; /* Do not generate CPU ACPI tables */ - int c1_battery; /* ACPI C1 on Battery Power */ int c2_battery; /* ACPI C2 on Battery Power */ int c3_battery; /* ACPI C3 on Battery Power */ diff --git a/src/cpu/intel/model_2065x/chip.h b/src/cpu/intel/model_2065x/chip.h index 21f75a3..d9b1057 100644 --- a/src/cpu/intel/model_2065x/chip.h +++ b/src/cpu/intel/model_2065x/chip.h @@ -4,8 +4,6 @@ #define SPEEDSTEP_APIC_MAGIC 0xACAC
struct cpu_intel_model_2065x_config { - u8 disable_acpi; /* Do not generate CPU ACPI tables */ - int c1_battery; /* ACPI C1 on Battery Power */ int c2_battery; /* ACPI C2 on Battery Power */ int c3_battery; /* ACPI C3 on Battery Power */ diff --git a/src/cpu/intel/model_206ax/chip.h b/src/cpu/intel/model_206ax/chip.h index 4e40830..a5a4312 100644 --- a/src/cpu/intel/model_206ax/chip.h +++ b/src/cpu/intel/model_206ax/chip.h @@ -4,8 +4,6 @@ #define SPEEDSTEP_APIC_MAGIC 0xACAC
struct cpu_intel_model_206ax_config { - u8 disable_acpi; /* Do not generate CPU ACPI tables */ - int c1_battery; /* ACPI C1 on Battery Power */ int c2_battery; /* ACPI C2 on Battery Power */ int c3_battery; /* ACPI C3 on Battery Power */
-
Angel Pons (Code Review) -
Nico Huber (Code Review)