Change in coreboot[master]: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

jitao shi (Code Review)

14 Jan 2020 14 Jan '20

1:40 p.m.

jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53

Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise.

Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Signed-off-by: Jitao Shi jitao.shi@mediatek.com --- M src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38401/1

diff --git a/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c b/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c index dc5a2ac..10753d9 100644 --- a/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c +++ b/src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c @@ -22,11 +22,11 @@ .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { - .pixel_clock = 159834, + .pixel_clock = 159916, .lvds_dual_channel = 0, .refresh = 60, - .ha = 1200, .hbl = 164, .hso = 114, .hspw = 10, - .va = 1920, .vbl = 33, .vso = 19, .vspw = 4, + .ha = 1200, .hbl = 164, .hso = 80, .hspw = 24, + .va = 1920, .vbl = 34, .vso = 20, .vspw = 4, .phsync = '-', .pvsync = '-', .x_mm = 135, .y_mm = 216, },

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Paul Menzel (Code Review)

14 Jan 14 Jan

2:59 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG@9 PS1, Line 9: Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise. Where did you get the parameters from? Data sheet? Please document that.

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG@10 PS1, Line 10: No bug URL?

jitao shi (Code Review)

15 Jan 15 Jan

12:49 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38401

to look at the new patch set (#2).

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53

Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise.

BRANCH=kukui BUG=b:147378025 TEST=bootup pass

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38401/2

Hung-Te Lin (Code Review)

6 Feb 6 Feb

3:35 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Gerrit-Change-Number: 38401 Gerrit-PatchSet: 2 Gerrit-Owner: jitao shi jitao.shi@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Feb 2020 03:35:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

3:36 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG@9 PS1, Line 9: Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise.

...

Where did you get the parameters from? Data sheet? Please document that.

Jitao can you provide the answer?

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG@10 PS1, Line 10:

...

No bug URL?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/38401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Gerrit-Change-Number: 38401 Gerrit-PatchSet: 2 Gerrit-Owner: jitao shi jitao.shi@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Feb 2020 03:36:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Jitao Shi (Code Review)

14 Feb 14 Feb

7:54 a.m.

Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG@9 PS1, Line 9: Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise.

...

Jitao can you provide the answer?

By this document: BOE NV101WUM-N53 preliminary product spec for lenovo20190717.pdf

-- To view, visit https://review.coreboot.org/c/coreboot/+/38401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Gerrit-Change-Number: 38401 Gerrit-PatchSet: 3 Gerrit-Owner: jitao shi jitao.shi@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com Gerrit-CC: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 14 Feb 2020 07:54:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

7:59 a.m.

Yu-Ping Wu has uploaded a new patch set (#4) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53

Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise. The parameters are based on BOE NV101WUM-N53 preliminary product spec.

BRANCH=kukui BUG=b:147378025 TEST=bootup pass

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38401/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Gerrit-Change-Number: 38401 Gerrit-PatchSet: 4 Gerrit-Owner: jitao shi jitao.shi@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com Gerrit-CC: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yu-Ping Wu (Code Review)

8 a.m.

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38401/1//COMMIT_MSG@9 PS1, Line 9: Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise.

...

By this document: BOE NV101WUM-N53 preliminary product spec for lenovo20190717. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Gerrit-Change-Number: 38401 Gerrit-PatchSet: 4 Gerrit-Owner: jitao shi jitao.shi@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com Gerrit-CC: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 14 Feb 2020 08:00:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

8:01 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Gerrit-Change-Number: 38401 Gerrit-PatchSet: 4 Gerrit-Owner: jitao shi jitao.shi@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com Gerrit-CC: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 14 Feb 2020 08:01:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

17 Feb 17 Feb

3:38 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38401 )

Change subject: mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53 ......................................................................

mb/google/kukui: fine tune the video timing of panel-BOE_TV101WUM_N53

Fine tune the video timing of panel-BOE_TV101WUM_N53 to avoid noise. The parameters are based on BOE NV101WUM-N53 preliminary product spec.

BRANCH=kukui BUG=b:147378025 TEST=bootup pass

Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Signed-off-by: Jitao Shi jitao.shi@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38401 Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c 1 file changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/38401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9e2cc90f233e87d712c2dc6f4441ca2e5423162 Gerrit-Change-Number: 38401 Gerrit-PatchSet: 5 Gerrit-Owner: jitao shi jitao.shi@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Casper Chang casper.chang@bitland.corp-partner.google.com Gerrit-CC: Jitao Shi jitao.shi@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1685

days inactive

1719

days old

coreboot-gerrit@coreboot.org

9 comments

6 participants

tags (0)

participants (6)

Hung-Te Lin (Code Review)
Jitao Shi (Code Review)
jitao shi (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Yu-Ping Wu (Code Review)